Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/comment: flesh out tests and fix OBSLocal same process authentication. #1318

Merged
merged 9 commits into from Jan 4, 2018

Conversation

@jberry-suse
Copy link
Contributor

jberry-suse commented Jan 3, 2018

Since generally helpful and making a variety of changes of last couple months to this heavily relied upon code it seems worth a few more tests.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 3, 2018

Coverage Status

Coverage increased (+0.2%) to 29.617% when pulling 7778d05 on jberry-suse:comment-tests into 98a659c on openSUSE:master.

jberry-suse added 6 commits Jan 3, 2018
…g user.

Previously, the user was changed, but the authentication not reset. For
osc.core calls made within the text context they would still run as Admin
while separate processes (like scripts) would run as the desired user. As
such this was not an issue before since only scripts were meant to run as
a different user.
@jberry-suse jberry-suse changed the title tests/comment_tests: flesh out tests tests/comment_tests: flesh out tests and fix OBSLocal same process authentication. Jan 3, 2018
@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Jan 3, 2018

With the addition of tests against local OBS (included in this PR) this should be full coverage. Even checks removing nested comments as that was bugged before which caused osc staging accept to crash as @DimStar77 noticed a while back.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 3, 2018

Coverage Status

Coverage increased (+0.6%) to 30.022% when pulling 2354232 on jberry-suse:comment-tests into 98a659c on openSUSE:master.

@jberry-suse jberry-suse changed the title tests/comment_tests: flesh out tests and fix OBSLocal same process authentication. tests/comment: flesh out tests and fix OBSLocal same process authentication. Jan 4, 2018
@jberry-suse jberry-suse merged commit 656cba4 into openSUSE:master Jan 4, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jberry-suse jberry-suse deleted the jberry-suse:comment-tests branch Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.