Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osclib/conf: allow devel projects to utilize tools that require conf. #1321

Merged
merged 1 commit into from Jan 4, 2018

Conversation

@jberry-suse
Copy link
Contributor

jberry-suse commented Jan 4, 2018

Originally, my thought was to add the flags back and take them as defaults if unable to load project config, but that would require the continued use of that pattern for all ReviewBots. repo-checker already has a pending issue to support devel projects (#1210) and makes use if this config in the same manor. It seems more useful to allow the config to work for non-openSUSE/SUSE projects. Obviously, StagingAPI will not work for them, but the config and local overrides should. Additionally, remote-config could work if a project decided to add a dashboard container, but not something I am worried about at the moment.

Tested using the following.

./check_source.py --osc-debug --debug --dry id 539170
# X11:Deepin/cogl@3 -> GNOME:Factory/cogl

The gnome-review-bot.service on packagelists should be changed:

- ExecStart=/usr/local/bin/check_source --ignore-devel --skip-add-reviews review
+ ExecStart=/usr/local/bin/check_source review

Optionally, --skip-add-reviews can remain, but all the individual reviews are disabled since no values are provided in config.

@jberry-suse jberry-suse changed the title osclib/conf: allow for devel projects to utilize tools that require conf. osclib/conf: allow devel projects to utilize tools that require conf. Jan 4, 2018
@jberry-suse jberry-suse force-pushed the jberry-suse:check_source-gnome-fix branch from 90166d1 to a6d367c Jan 4, 2018
@openSUSE openSUSE deleted a comment from coveralls Jan 4, 2018
@jberry-suse jberry-suse force-pushed the jberry-suse:check_source-gnome-fix branch from a6d367c to 562743e Jan 4, 2018
@openSUSE openSUSE deleted a comment from coveralls Jan 4, 2018
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 4, 2018

Coverage Status

Coverage remained the same at 29.419% when pulling 562743e on jberry-suse:check_source-gnome-fix into 98a659c on openSUSE:master.

@DimStar77

This comment has been minimized.

Copy link
Contributor

DimStar77 commented Jan 4, 2018

Is this really the fix for #1204? That isse was about factory-auto (a bot running on oS:F, thus having a config)

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Jan 4, 2018

Removed the issue fix. Looks like I confused with another issue or just direct comment about the bot running for GNOME:Factory.

@DimStar77

This comment has been minimized.

Copy link
Contributor

DimStar77 commented Jan 4, 2018

Ok, then this LGTM. will change the gnome review bot servuce ince nerged/deployed

@DimStar77 DimStar77 merged commit b0cd970 into openSUSE:master Jan 4, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@DimStar77

This comment has been minimized.

Copy link
Contributor

DimStar77 commented Jan 4, 2018

Deployed, and gnome-review-bot service updated

@lnussel

This comment has been minimized.

Copy link
Member

lnussel commented Jan 5, 2018

I had to revert this. Breaks SLE. The entries in the dict are not ordered so not clear which one takes precedence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.