Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osclib/conf: order config defaults by priority and allow devel projects to utilize. #1327

Merged

Conversation

@jberry-suse
Copy link
Contributor

jberry-suse commented Jan 9, 2018

  • 61c8350:
    osclib/conf: allow devel projects to utilize tools that require conf.

  • 8657502:
    osclib/conf: order config defaults by priority.

    Ensures that less specific patterns do not overtake more specific patterns
    by allowing for priority based ordering.

Followup to #1321 which was reverted due to catch-all pattern being ordered before SLE. The lack of ordering is pre-existing, but luckily not encountered. I went ahead and added an optional priority key to allow for clear sorting. This could also be done by defining the defaults using OrderedDict, but this seems preferable.

I added a lower priority to the general (older) SLE config since it would gobble up SLE-15 if mis-ordered. Included a test while at it. :)

jberry-suse added 2 commits Jan 9, 2018
Ensures that less specific patterns do not overtake more specific patterns
by allowing for priority based ordering.
@jberry-suse jberry-suse merged commit 2b037a0 into openSUSE:master Jan 9, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jberry-suse jberry-suse deleted the jberry-suse:conf-allow-arbitrary-project branch Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.