Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkglistgen: migrate bash scripts to python followup #1328

Merged

Conversation

@jberry-suse
Copy link
Contributor

jberry-suse commented Jan 9, 2018

As indicated in #1312, I had not yet performed a complete run so it was not clear everything worked. The following as tweaks needed to fix some minor issues and added --dry handling for undelete_package() from wrappers. One interesting bit is LOCALES_FROM was set to openSUSE-product, but as far as I can tell either this was not trickled all the way down or should have been openSUSE.product (period instead of dash) [@lnussel thoughts?]. Also added config mapping for remaining flags which is likely main bit needed for SLE.

Still completing a full run locally before updating tortuga.

  • ce650ff:
    pkglistgen: update_and_solve: include step in output for debugging.

  • 407a802:
    pkglistgen: update_and_solve: handle --dry for undelete_package().

  • 16fa961:
    pkglistgen: update_and_solve: include ignore_unresolvable and local options for solve.

  • 8892c0d:
    pkglistgen: update_and_solve: set input_dir to group_dir for solve.

  • c06050a:
    osclib/conf: correct Leap 15.0 default locales-from from - to . product.

  • e1b85fd:
    systemd/pkglistgen: add update_and_solve subcommand.

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Jan 9, 2018

Seems like this does the trick although with Leap 15.0 going through full rebuild perhaps something is hiding. Otherwise, I'll deploy tomorrow.

@jberry-suse jberry-suse force-pushed the jberry-suse:pkglistgen-migrate-followup branch from ce650ff to 3ae00c1 Jan 9, 2018
@openSUSE openSUSE deleted a comment from coveralls Jan 9, 2018
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 9, 2018

Coverage Status

Changes Unknown when pulling 3ae00c1 on jberry-suse:pkglistgen-migrate-followup into ** on openSUSE:master**.

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Jan 9, 2018

It also does not appear INCLUDE_SUGGESTED was passing through before as my diff shows a number of changes pertaining to the inclusion of suggested.

@@ -206,9 +228,15 @@
     <package name="ifplugd"/> <!-- reason: base:patterns-base-console -->
     <package name="info"/> <!-- reason: supplements:biosdevname -->
     <package name="initviocons"/> <!-- reason: base:patterns-base-console -->
+    <package name="inputproto-devel"/> <!-- reason: x11:suggested:patterns-base-x11_opt:xorg-x11-server-sdk -->
     <package name="insserv-compat"/> <!-- reason: base:patterns-base-console -->
+    <package name="install-initrd-openSUSE"/> <!-- reason: yast:suggested:patterns-yast-yast2_basis:install-initrd-openSUSE -->
     <package name="intlfonts"/> <!-- reason: x11:patterns-base-x11 -->
     <package name="intlfonts-euro-bitmap-fonts"/> <!-- reason: x11:patterns-base-x11 -->
+    <package name="ipa-gothic-fonts"/> <!-- reason: x11:suggested:patterns-base-x11_opt:ipa-gothic-fonts -->
+    <package name="ipa-mincho-fonts"/> <!-- reason: x11:suggested:patterns-base-x11_opt:ipa-mincho-fonts -->
+    <package name="ipa-pgothic-fonts"/> <!-- reason: x11:suggested:patterns-base-x11_opt:ipa-pgothic-fonts -->
+    <package name="ipa-pmincho-fonts"/> <!-- reason: x11:suggested:patterns-base-x11_opt:ipa-pmincho-fonts -->
     <package name="iproute2"/> <!-- reason: supplements:biosdevname -->
     <package name="ipset"/> <!-- reason: base:patterns-base-console -->
     <package name="iptables"/> <!-- reason: base:patterns-base-console -->
@jberry-suse jberry-suse merged commit b41bbd1 into openSUSE:master Jan 9, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Jan 9, 2018

The deployed code had not been updated recently since the import requests line introduced in 8e3fcbf caused ImportError: No module named requests which should explain why the suggests are not seen production even though the code would create them.

@jberry-suse jberry-suse deleted the jberry-suse:pkglistgen-migrate-followup branch Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.