Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs_clone: workaround openSUSE:Factory meta revision 429 self reference. #1338

Merged
merged 2 commits into from Jan 11, 2018

Conversation

@jberry-suse
Copy link
Contributor

jberry-suse commented Jan 11, 2018

  • ecda2f0:
    obs_clone: workaround openSUSE:Factory meta revision 429 self reference.

  • 494702b:
    obs_clone: set the exit code to 1 when HTTPError encountered.

Fixes #1335. Need to verify travis-ci is happy.

I have some further improvements I made to handling links which enable cloning the rings, but even with that the super loop self reference is a bit too much without a solver so this seems like best solution since it is temporary. Simply revert ecda2f0 once reverted in Factory.

Included changed to set exit code to 1 on exception so that travis-ci will stop on the failure instead of running tests.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 11, 2018

Coverage Status

Coverage decreased (-0.02%) to 30.879% when pulling ecda2f0 on jberry-suse:obs_clone-ring-1-failure into 453674c on openSUSE:master.

@jberry-suse jberry-suse merged commit 9ab0211 into openSUSE:master Jan 11, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jberry-suse jberry-suse deleted the jberry-suse:obs_clone-ring-1-failure branch Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.