Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osclib/request_splitter: rework quick strategy to handle Leap 15.0 workflow #1343

Merged
merged 1 commit into from Jan 15, 2018

Conversation

@jberry-suse
Copy link
Contributor

jberry-suse commented Jan 12, 2018

The addition of factory-auto and repo-checker reviews need to be allowed
since they are always present and do not constitute a non-quick review.
In an attempt to future proof the strategy the allowed review groups are
taken from the project configuration and repo-checker from config.

Fixes #1340.

@jberry-suse jberry-suse force-pushed the jberry-suse:request_splitter-quick-rework branch from b67964b to a3f55d4 Jan 12, 2018
@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Jan 12, 2018

Reworked, to improve robustness of xpath.

@openSUSE openSUSE deleted a comment from coveralls Jan 12, 2018
…rkflow.

The addition of factory-auto and repo-checker reviews need to be allowed
since they are always present and do not constitute a non-quick review.
In an attempt to future proof the strategy the allowed review groups are
taken from the project configuration and repo-checker from config.
@jberry-suse jberry-suse force-pushed the jberry-suse:request_splitter-quick-rework branch from a3f55d4 to 5519162 Jan 12, 2018
@openSUSE openSUSE deleted a comment from coveralls Jan 12, 2018
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 12, 2018

Coverage Status

Coverage decreased (-0.01%) to 30.86% when pulling 5519162 on jberry-suse:request_splitter-quick-rework into 41846c5 on openSUSE:master.

@lnussel lnussel merged commit e938219 into openSUSE:master Jan 15, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jberry-suse jberry-suse deleted the jberry-suse:request_splitter-quick-rework branch Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.