Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osclib/request_splitter: allow special packages to be empty. #1344

Merged

Conversation

@jberry-suse
Copy link
Contributor

jberry-suse commented Jan 12, 2018

@lnussel I added this variable override a while back, but seems we forgot about it since you asked in IRC the other day. Given it sounds like you would like no special packages for Leap I updated code to handle empty string variable override.

I'll go ahead and update project config for Leap 15.0 to set the special list to empty, but feel free to update.

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Jan 12, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 12, 2018

Coverage Status

Coverage remained the same at 30.872% when pulling 3d43985 on jberry-suse:request_splitter-special-config into 41846c5 on openSUSE:master.

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Jan 12, 2018

For now it will just keep the default list until this is deployed. Can also set the list to any random package name that it will never hit.

@lnussel lnussel merged commit ad449c6 into openSUSE:master Jan 15, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jberry-suse jberry-suse deleted the jberry-suse:request_splitter-special-config branch Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.