Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReviewBot: do not bother commenting for unhandled request type. #1426

Merged

Conversation

@jberry-suse
Copy link
Contributor

jberry-suse commented Mar 5, 2018

For consistency this would still make sense to post as a "report", but given the lack of such a facility in OBS disable comment to reduce noise.

./leaper.py -A ibs --dry --verbose id 156275
[I] checking 156275
[E] unhandled request type set_bugowner
[I] 156275 needs review by [leap-reviewers](/group/show/leap-reviewers)
[I] POST https://api.suse.de/request/156275?by_group=leap-reviewers&cmd=addreview
[I] can't change state, 156275 does not have the reviewer
[I] 156275 accepted: ok: unhandled request type set_bugowner

Fixes #1422.

For consistency this would still make sense to post as a "report", but
given the lack of such a facility in OBS disable comment to reduce noise.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 5, 2018

Coverage Status

Coverage remained the same at 30.648% when pulling 3c25b8a on jberry-suse:ReviewBot-default-no-comment into bac6644 on openSUSE:master.

@nilxam

This comment has been minimized.

Copy link
Contributor

nilxam commented Mar 6, 2018

LGTM

@jberry-suse jberry-suse merged commit a9ec91f into openSUSE:master Mar 6, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jberry-suse jberry-suse deleted the jberry-suse:ReviewBot-default-no-comment branch Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.