Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osclib/staging-api: lazy-load all config values to allow for placement in remote config. #1432

Merged
merged 4 commits into from Mar 8, 2018

Conversation

@jberry-suse
Copy link
Contributor

jberry-suse commented Mar 7, 2018

  • e450a15:
    osclib/stagingapi: rename main_repo to cmain_repo.

    The previous name is inconsistent and did not work with general lazy laod.

  • 4bd9e9a:
    osclib/stagingapi: rename delreq_review to cdelreq_review.

    The previous name is inconsistent and did not work with general lazy laod.

  • d790a2c:
    osclib/stagingapi: rename cstaging_nocleanup to cnocleanup_packages.

    The previous name is inconsistent and did not work with general lazy laod.

  • e3168d6:
    osclib/staging-api: lazy-load all config values to allow for placement in remote config.

Feel free to test this out as we have many use-cases and few tests. I made sure the values I replaced worked for Factory which means the lazy-load worked and confirmed that `memoize handlers seem to still work as well.

Further fixes #1428 as even the staging-group should be override-able in remote config.

jberry-suse added 4 commits Mar 7, 2018
The previous name is inconsistent and did not work with general lazy laod.
The previous name is inconsistent and did not work with general lazy laod.
The previous name is inconsistent and did not work with general lazy laod.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 7, 2018

Coverage Status

Coverage decreased (-0.01%) to 30.614% when pulling e450a15 on jberry-suse:stagingapi-lazy-load-all into f6eae67 on openSUSE:master.

@coolo

This comment has been minimized.

Copy link
Member

coolo commented Mar 8, 2018

works for my uses if I ask it to load remote for suse:

--- a/osclib/conf.py
+++ b/osclib/conf.py
@@ -96,7 +96,6 @@ DEFAULT = {
     },
     r'SUSE:(?P<project>SLE-15.*$)': {
         'staging': 'SUSE:%(project)s:Staging',
-        'staging-group': 'sle-staging-managers',  # '%(project.lower)s-staging',
         'staging-archs': 'i586 x86_64',
         'staging-dvd-archs': '',
         'rings': 'SUSE:%(project)s:Rings',
@@ -119,10 +118,8 @@ DEFAULT = {
     },
     r'SUSE:(?P<project>.*$)': {
         'staging': 'SUSE:%(project)s:Staging',
-        'staging-group': 'sle-staging-managers',  # '%(project.lower)s-staging',
         'staging-archs': 'i586 x86_64',
         'staging-dvd-archs': '',
-        'nocleanup-packages': 'Test-DVD-x86_64 sles-release',
         'rings': None,
         'nonfree': None,
         'rebuild': None,
@@ -130,7 +127,6 @@ DEFAULT = {
         'openqa': None,
         'lock': 'SUSE:%(project)s:Staging',
         'lock-ns': 'SUSE',
-        'remote-config': False,
         'delreq-review': None,
         'main-repo': 'standard',
         'priority': '100', # Lower than SLE-15 since less specific.
@@ -151,7 +147,6 @@ DEFAULT = {
         'lock-ns': None,
         'delreq-review': None,
         'main-repo': 'openSUSE_Factory',
-        'remote-config': False,
         'priority': '1000', # Lowest priority as only a fallback.
     },
 }
@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Mar 8, 2018

  •    'remote-config': False,
    

One item to note, if we make that change in git we'll need to ensure any projects that match have a dashboard container. Obviously, if you just use locally no issues.

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Mar 8, 2018

  •    'staging-group': 'sle-staging-managers',  # '%(project.lower)s-staging',
    

Presumably it should work without this since remote should override defaults.

I'll leave any follow-ups related to remote-config in your hands since you have a better idea about the usage.

@jberry-suse jberry-suse merged commit 568be98 into openSUSE:master Mar 8, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jberry-suse jberry-suse deleted the jberry-suse:stagingapi-lazy-load-all branch Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.