Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source devel project check carried over from flawed adi logic #662

Merged
merged 3 commits into from Feb 6, 2017

Conversation

@jberry-suse
Copy link
Contributor

jberry-suse commented Feb 1, 2017

Followup on confirmation that previous adi logic was bad and some further testing.

  • Remove incorrect devel project lookup copied from adi.
  • Move @devel_project to action/target.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 1, 2017

Coverage Status

Coverage increased (+0.03%) to 45.306% when pulling 73b1f93 on jberry-suse:remove-source-devel into d08d430 on openSUSE:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 1, 2017

Coverage Status

Coverage increased (+0.03%) to 45.306% when pulling b022875 on jberry-suse:remove-source-devel into d08d430 on openSUSE:master.

def devel_project_get(self, target_project):
if self.api.project.startswith('openSUSE:'):
return self.api.get_devel_project('openSUSE:Factory', target_project)
return None

This comment has been minimized.

Copy link
@lnussel

lnussel Feb 1, 2017

Member

that is a bit too oversimplified I think :) it stil does make sense to check for devel in the target (leap for example has a handful packages with devel project set). The previous mistake was to check the source. Factory should be used as fallback.

if devel is None and self.api.project.startswith('openSUSE:'):
devel = self.api.get_devel_project('openSUSE:Factory', target_project)
return devel
def devel_project_get(self, target_project):

This comment has been minimized.

Copy link
@lnussel

lnussel Feb 1, 2017

Member

is actually target_package but project is needed too, see below

jberry-suse added 3 commits Feb 1, 2017
…adi.

Instead of checking action/source the action/target should be used.
With the source no longer being checked for devel project and the fact
that delete requests and such will not have source, but make sense to
have a devel project moving to target makes more sense.
@jberry-suse jberry-suse force-pushed the jberry-suse:remove-source-devel branch from b022875 to 38dbf5b Feb 1, 2017
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 1, 2017

Coverage Status

Coverage decreased (-0.01%) to 45.263% when pulling 38dbf5b on jberry-suse:remove-source-devel into 094dee5 on openSUSE:master.

@lnussel lnussel merged commit 38dbf5b into openSUSE:master Feb 6, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jberry-suse jberry-suse deleted the jberry-suse:remove-source-devel branch Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.