Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request_splitter: delete requests should always be considered in a ring. #674

Closed

Conversation

@jberry-suse
Copy link
Contributor

jberry-suse commented Feb 8, 2017

An alternative approach to #671 which places delete request not otherwise in a ring in a fake ring "delete" since it is only used for filtering/grouping. Could place in an existing ring if desired, but this keeps it out of the adi list.

@jberry-suse jberry-suse requested a review from nilxam Feb 8, 2017
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 8, 2017

Coverage Status

Coverage decreased (-0.03%) to 45.317% when pulling 36497f0 on jberry-suse:splitter-delete-ring into 1bd141a on openSUSE:master.

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Feb 8, 2017

Depends on #676 3de3cae

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Feb 8, 2017

I decided to just include in the other PR.

@jberry-suse jberry-suse closed this Feb 8, 2017
@jberry-suse jberry-suse deleted the jberry-suse:splitter-delete-ring branch Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.