Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request_splitter: house keeping (and fix for SLE [non-ring] workflow) #676

Merged
merged 6 commits into from Feb 9, 2017

Conversation

@jberry-suse
Copy link
Contributor

jberry-suse commented Feb 8, 2017

  • list: remove case for delete request without ring.
  • non-ring projects consider all requests in rings.
  • utilize ring attribute rather then lookup again.
  • rather than an empty group name use 00.
jberry-suse added 4 commits Feb 8, 2017
Sorts to the top and is consistent with old behavior.
This case should no longer exist as non-ring requests will have already
be separated out of this loop.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 8, 2017

Coverage Status

Coverage increased (+0.03%) to 45.374% when pulling 08f2218 on jberry-suse:sle-list into c41e042 on openSUSE:master.

@jberry-suse

This comment has been minimized.

Copy link
Contributor Author

jberry-suse commented Feb 8, 2017

For those curious I ran a bisect using a script (only works if >= 1 request in queue):

osc -A ibs staging -p SUSE:SLE-12-SP3:GA list | grep "Not in a ring"
if [ $? -eq 0 ] ; then
  exit 1
fi

Which reveal the request_splitter broke SLE workflow.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 8, 2017

Coverage Status

Coverage remained the same at 45.346% when pulling ef5de87 on jberry-suse:sle-list into c41e042 on openSUSE:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 8, 2017

Coverage Status

Coverage remained the same at 45.346% when pulling 5da8f89 on jberry-suse:sle-list into c41e042 on openSUSE:master.

@nilxam

This comment has been minimized.

Copy link
Contributor

nilxam commented Feb 9, 2017

LGTM

@nilxam nilxam merged commit 8cab152 into openSUSE:master Feb 9, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jberry-suse jberry-suse deleted the jberry-suse:sle-list branch Feb 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.