Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osc-staging: add missing documentation and correct/clean existing #686

Merged
merged 4 commits into from Feb 14, 2017

Conversation

@jberry-suse
Copy link
Contributor

jberry-suse commented Feb 10, 2017

  • add missing documentation and correct/clean existing.
  • check command does not support 2 arguments.
  • adi command min should be 0 for consistency.
  • drop extraneous space in freeze method call.
@jberry-suse jberry-suse changed the title Document staging commands add missing documentation and correct/clean existing Feb 10, 2017
@jberry-suse jberry-suse changed the title add missing documentation and correct/clean existing osc-staging: add missing documentation and correct/clean existing Feb 10, 2017
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 10, 2017

Coverage Status

Coverage remained the same at 45.346% when pulling 020410f on jberry-suse:document-staging-commands into 6eefb42 on openSUSE:master.

packages based on the grouping options used. The default grouping is by
source project. When adi stagings are ready the request will be marked
ready, unstaged, and the adi staging deleted. If the user has permission
to accept, the requests marked ready will be accepted.

This comment has been minimized.

Copy link
@DimStar77

DimStar77 Feb 10, 2017

Contributor

the adi command does not accept any requests... it only sets all 'reviews' as accepted; once 'adi' is completed, the submit request is in state 'new'

osc staging accept (with or without letter) accepts the requests finally

This comment has been minimized.

Copy link
@jberry-suse

jberry-suse Feb 10, 2017

Author Contributor
diff --git a/osc-staging.py b/osc-staging.py
index d4d53f0..6a98d65 100644
--- a/osc-staging.py
+++ b/osc-staging.py
@@ -110,6 +110,8 @@ def do_staging(self, subcmd, opts, *args):
 
     "accept" will accept all requests in
         $PROJECT:Staging:<LETTER> into $PROJECT
+        If openSUSE:* project, requests marked ready from adi stagings will also
+        be accepted.
 
     "acheck" will check if it is safe to accept new staging projects
         As $PROJECT is syncing the right package versions between
@@ -120,8 +122,7 @@ def do_staging(self, subcmd, opts, *args):
         requests where applicable. New adi stagings will be created for new
         packages based on the grouping options used. The default grouping is by
         source project. When adi stagings are ready the request will be marked
-        ready, unstaged, and the adi staging deleted. If the user has permission
-        to accept, the requests marked ready will be accepted.
+        ready, unstaged, and the adi staging deleted.
 
     "check" will check if all packages are links without changes
 
@jberry-suse jberry-suse force-pushed the jberry-suse:document-staging-commands branch from 020410f to 7307b8e Feb 10, 2017
@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 10, 2017

Coverage Status

Coverage remained the same at 45.346% when pulling 7307b8e on jberry-suse:document-staging-commands into 6eefb42 on openSUSE:master.

@lnussel lnussel merged commit e5c5a07 into openSUSE:master Feb 14, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jberry-suse jberry-suse deleted the jberry-suse:document-staging-commands branch Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.