Add compatibility with Debian's obs-build #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Debian and Ubuntu build is renamed to obs-build for disambiguation purposes. Add a simple check to use the correct paths if running on Debian and use /usr/bin/obs-build and /usr/lib/obs-build if so.
|
Merged. Thanks for the PR!
(ps., actually, the "import os" in commandline.py is not needed,
but I prefer your explicit import as well:) ).
|
|
Thanks! I prefer explicit imports too. I have now forwarded the patch to Debian as well: |
|
I've also sent a request to make osc depend on "build | obs-build" instead of "build", so that it can be installed with Debian's version too: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In Debian and Ubuntu build is renamed to obs-build for disambiguation
purposes.
Add a simple check to use the correct paths if running on Debian and
use /usr/bin/obs-build and /usr/lib/obs-build if so.
This is a constant source of errors and confusion for a lot of our users. Hopefully this very simple fix can put an end to that.