chroot: mount /dev/shm #444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise programs like 'gyp' fail to work that need it for interprocess communication
|
First of all thanks for the PR!
On 2018-09-20 20:31:07 -0700, Bernhard M. Wiedemann wrote:
otherwise programs like 'gyp' fail to work
that need it for interprocess communication
LGTM, but could you also add the error handling for devshm_mount_err?
|
|
The build script is supporting to jump into shell now (works at least for chroot and kvm). IMHO we should replace the code from this command entirely with that (and fix stuff there in case) |
|
we use now the build script for jumping into chroot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
otherwise programs like 'gyp' fail to work
that need it for interprocess communication