-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated layout of ichain sign in page #1110
Updated layout of ichain sign in page #1110
Conversation
@@ -9,3 +9,7 @@ | |||
- if devise_mapping.lockable? && resource_class.unlock_strategy_enabled?(:email) && controller_name != 'unlocks' | |||
= link_to "Didn't receive unlock instructions?", new_unlock_path(resource_name) | |||
%br | |||
|
|||
- if devise_mapping.ichain_registerable? | |||
= link_to "Sign up", new_ichain_registration_path(resource_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up is not possible when ichain is enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, new_ichain_registration_path(resource_name)
should redirect you to the sign up page of the iChain provider, shouldn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, true, that's what happens in production.
The correct path though is new_user_ichain_registration_path
@jmks Where did you find the path you are using new_ichain_registration_path
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@differentreality It's a helper in the devise_ichain_authenticatable
gem that is used in their views. It seems to be used in one other place:
app/views/layouts/_navigation.html.haml
47: %li{:class=> "#{active_nav_li(new_ichain_registration_path('user'))}"}
48: = link_to(new_ichain_registration_path('user')) do
Should I update all usages of new_ichain_registration_path
to new_user_ichain_registration_path
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you are right... Well in that case no, you don't have to change it.
%h3.panel-title | ||
Sign in | ||
.panel-body | ||
= semantic_form_for "", method: :post, enctype: 'application/x-www-form-urlencoded', url: @login_url do |f| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For styling purposes, please use single quotes here.
%h3.panel-title | ||
Sign in (TEST MODE) | ||
.panel-body | ||
= semantic_form_for "", method: :post, enctype: 'application/x-www-form-urlencoded', url: @login_url do |f| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These quotes too?
👍 thank you for the contribution @jmks! |
Fix for #1098
I basically merged the content of the devise ichain views with the current database_authenticatable sign in page.
I could sign in successfully using ichain test mode. When not in test mode, how can I test this locally? Do I just need to create an openSUSE account and try to sign in, or is there more setup? (I am not familiar with ichain at all)