Fix event type description display on proposals#new and proposals#edit#1210
Conversation
|
That seems to be working :-) Thank you @jmks for working on this! A suggestion: when you want to refer to files and lines in files, please include a link. If you see a file in github you can click on the line number and then the line is included in the url and you can use that url in your comments to properly link to the file/line you want. |
|
@jmks there is actually one more thing you need to check. The files you touched are shared with the admin view of editing the proposal, and that's not showing up properly. |
|
@differentreality I'm looking at routes like The admin view file that's rendered just renders one of the files I changed. Should I be looking somewhere else? |
|
Try editing a proposal with event type which is not the first one in the list. |
|
@jmks is that what you see when the page is loaded without touching anything? Without selecting the event type from the drop down? |
|
@differentreality Sorry for the delay. Yes, that is what I see immediately after the page loads (Chrome 53.0.2785.116 (64-bit)). |
|
OK this seems to be working :) |

Fix #1208
On load the correct event type description is displayed by osem.js:166 when the dropdown value is set. Re-showing the text would be harmless, but it triggers a change event listener here
Just removing these lines seems to display the description correctly for different event types and renders from errors, on both
proposals#newandproposals#edit.