Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event type description display on proposals#new and proposals#edit #1210

Merged

Conversation

@jmks
Copy link
Contributor

jmks commented Oct 5, 2016

Fix #1208

On load the correct event type description is displayed by osem.js:166 when the dropdown value is set. Re-showing the text would be harmless, but it triggers a change event listener here

Just removing these lines seems to display the description correctly for different event types and renders from errors, on both proposals#new and proposals#edit.

@differentreality

This comment has been minimized.

Copy link
Contributor

differentreality commented Oct 17, 2016

That seems to be working :-) Thank you @jmks for working on this!

A suggestion: when you want to refer to files and lines in files, please include a link. If you see a file in github you can click on the line number and then the line is included in the url and you can use that url in your comments to properly link to the file/line you want.

@differentreality

This comment has been minimized.

Copy link
Contributor

differentreality commented Oct 17, 2016

@jmks there is actually one more thing you need to check. The files you touched are shared with the admin view of editing the proposal, and that's not showing up properly.
We should fix that as well!

@jmks

This comment has been minimized.

Copy link
Contributor Author

jmks commented Oct 19, 2016

@differentreality I'm looking at routes like admin/conferences/:conference_id/program/events/:id/edit and the help text shows up correctly.

The admin view file that's rendered just renders one of the files I changed.

Should I be looking somewhere else?

@differentreality

This comment has been minimized.

Copy link
Contributor

differentreality commented Oct 19, 2016

Try editing a proposal with event type which is not the first one in the list.

@jmks

This comment has been minimized.

Copy link
Contributor Author

jmks commented Oct 20, 2016

Am I looking in the right spot?

osem admin edit events highlights

Maybe a browser difference, and I should explicitly set the selected item.

@differentreality

This comment has been minimized.

Copy link
Contributor

differentreality commented Oct 21, 2016

@jmks is that what you see when the page is loaded without touching anything? Without selecting the event type from the drop down?

@jmks

This comment has been minimized.

Copy link
Contributor Author

jmks commented Oct 25, 2016

@differentreality Sorry for the delay. Yes, that is what I see immediately after the page loads (Chrome 53.0.2785.116 (64-bit)).

@hennevogel hennevogel temporarily deployed to osem-demo-pr-1210 Oct 28, 2016 Inactive
@hennevogel hennevogel temporarily deployed to osem-demo-pr-1210 Nov 22, 2016 Inactive
@differentreality

This comment has been minimized.

Copy link
Contributor

differentreality commented Nov 24, 2016

OK this seems to be working :)
👍 good work @jmks

@differentreality differentreality merged commit d07de3c into openSUSE:master Nov 24, 2016
3 checks passed
3 checks passed
Hakiri No security warnings were found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 85.51%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.