New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly urls for tracks #1565

Merged
merged 1 commit into from Jul 4, 2017

Conversation

2 participants
@AEtherC0r3
Contributor

AEtherC0r3 commented Jun 30, 2017

Don't use tracks ids in urls
Add short_name to tracks and use that in urls as the identifier

@AEtherC0r3 AEtherC0r3 added the GSoC label Jun 30, 2017

@AEtherC0r3 AEtherC0r3 force-pushed the AEtherC0r3:friendly_names_for_tracks branch 2 times, most recently from 9b4828d to 5ec8472 Jun 30, 2017

@AEtherC0r3

This comment has been minimized.

Contributor

AEtherC0r3 commented Jul 3, 2017

Tracks#new
2017-07-03 19-23-31

Tracks#index
2017-07-03 19-23-59

Tracks#edit
2017-07-03 19-24-15

Url from Tracks#show
2017-07-03 19-24-52

@differentreality

This comment has been minimized.

Contributor

differentreality commented Jul 4, 2017

This looks nice @AEtherC0r3 :D 👍

Friendly urls for tracks
Don't use tracks ids in urls
Add short_name to tracks and use that in urls as the identifier

@AEtherC0r3 AEtherC0r3 force-pushed the AEtherC0r3:friendly_names_for_tracks branch from 3a2d0f1 to 71e6970 Jul 4, 2017

@AEtherC0r3 AEtherC0r3 merged commit 95fbd10 into openSUSE:master Jul 4, 2017

3 checks passed

Hakiri No security warnings were found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 86.037%
Details

@AEtherC0r3 AEtherC0r3 deleted the AEtherC0r3:friendly_names_for_tracks branch Jul 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment