New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to run OSEM on heroku #900

Merged
merged 13 commits into from Apr 29, 2016

Conversation

Projects
None yet
3 participants
@hennevogel
Member

hennevogel commented Mar 22, 2016

Next up: Making file upload work. I'm contemplating of using https://github.com/cloudinary/cloudinary_gem for this

@ChrisBr ChrisBr self-assigned this Mar 23, 2016

@@ -10,7 +10,7 @@ def new
redirect_to edit_conference_conference_registrations_path(@conference.short_title)
return
# ichain does not allow us to create users during registration
elsif CONFIG['authentication']['ichain']['enabled'] && !current_user
elsif (ENV['OSEM_ICHAIN_ENABLED'] == 'true') && !current_user

This comment has been minimized.

@ChrisBr

ChrisBr Mar 23, 2016

Member

Hm, is there no way to parse the ENV variable into a boolean?

This comment has been minimized.

@hennevogel

hennevogel Mar 23, 2016

Member

No it's always a string. Usually this is done by existance. Either it is set, no matter the content, or not. Would you like that more?

@@ -7,12 +7,12 @@ def get_values(conference, user, event = nil)
'conference_start_date' => conference.start_date,
'conference_end_date' => conference.end_date,
'registrationlink' => Rails.application.routes.url_helpers.conference_conference_registrations_url(
conference.short_title, host: CONFIG['url_for_emails']),
conference.short_title, host: (ENV['OSEM_HOSTNAME'] || 'localhost:3000')),

This comment has been minimized.

@ChrisBr

ChrisBr Mar 23, 2016

Member

Actually I don't like to hardcode (ENV['OSEM_HOSTNAME'] || 'localhost:3000')
(same for all the others)

Imagine you don't use port 3000 in dev ...

This comment has been minimized.

@hennevogel

hennevogel Mar 23, 2016

Member

Then set the variable :-) Same as with the config file...

@@ -11,7 +11,7 @@
%legend
%span
=link_to('#signup', role: 'tab', "aria-controls" => "home", "data-toggle" => "tab") do
= CONFIG['name']
= ENV['OSEM_NAME'] || 'OSEM'

This comment has been minimized.

@ChrisBr

ChrisBr Mar 23, 2016

Member

And I also don't like to hardcode OSEM on various places ...

@ChrisBr

This comment has been minimized.

Member

ChrisBr commented Apr 1, 2016

Have you tried if it still works with vagrant?
(with a new box and with an existing box?)

@hennevogel hennevogel force-pushed the demo branch 4 times, most recently from 460b9e7 to 494df2d Apr 5, 2016

@hennevogel

This comment has been minimized.

Member

hennevogel commented Apr 22, 2016

Tested with a newly provisioned vagrant box, everything works as expected

@hennevogel hennevogel temporarily deployed to osem-demo Apr 22, 2016 Inactive

@hennevogel hennevogel force-pushed the demo branch 2 times, most recently from 7b3f1dd to 773e917 Apr 22, 2016

@hennevogel hennevogel temporarily deployed to osem-demo Apr 22, 2016 Inactive

@hennevogel hennevogel temporarily deployed to osem-demo Apr 22, 2016 Inactive

@hennevogel hennevogel temporarily deployed to osem-demo Apr 22, 2016 Inactive

@hennevogel hennevogel temporarily deployed to osem-demo Apr 26, 2016 Inactive

@hennevogel hennevogel temporarily deployed to osem-demo Apr 26, 2016 Inactive

@hennevogel

This comment has been minimized.

Member

hennevogel commented Apr 27, 2016

cloudinary is done in #970

# Generate your own with rake secret
# secret_key_base: '12345'
########## OMNIAUT Providers ##########

This comment has been minimized.

@differentreality

differentreality Apr 29, 2016

Contributor

typo: OMNIAUTH

# Your errbit API key
# errbit_key: '12345'
########## OMNIAUT Providers ##########

This comment has been minimized.

@differentreality

differentreality Apr 29, 2016

Contributor

typo: OMNIAUTH

#{path}
is deprecated. Please use the environment environment variables

This comment has been minimized.

@differentreality

differentreality Apr 29, 2016

Contributor

one environment enough?

@hennevogel hennevogel force-pushed the demo branch 2 times, most recently from b832266 to 1f29c2d Apr 29, 2016

@hennevogel

This comment has been minimized.

Member

hennevogel commented Apr 29, 2016

@differentreality fixed the typos

@hennevogel hennevogel temporarily deployed to osem-demo Apr 29, 2016 Inactive

@differentreality

This comment has been minimized.

Contributor

differentreality commented Apr 29, 2016

I havent tried it with vagrant, other than that everything looks good 👍

hennevogel added some commits Mar 22, 2016

@hennevogel hennevogel merged commit ac0659d into master Apr 29, 2016

4 checks passed

Hakiri No security warnings were found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on master at 84.494%
Details

@hennevogel hennevogel deleted the demo branch Jun 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment