New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to carrierwave for for upload management #970

Merged
merged 13 commits into from Apr 29, 2016

Conversation

Projects
None yet
3 participants
@hennevogel
Member

hennevogel commented Apr 27, 2016

It's way more flexible and brings simple support to use cloud storage like AWS or cloudinary. Additionally it fits perfect for our needs to host on PaaS services like heroku.

hennevogel added some commits Apr 27, 2016

@hennevogel hennevogel force-pushed the hennevogel:feature_cloudinary branch from 2f6637d to 8fc57e3 Apr 27, 2016

@@ -0,0 +1,4 @@
production:
cloud_name: "sample"
api_key: "874837483274837"

This comment has been minimized.

@differentreality

differentreality Apr 29, 2016

Contributor

Are those keys meant to be public?

This comment has been minimized.

@hennevogel

hennevogel Apr 29, 2016

Member

They are examples (taken from the cloudinary docu)

@differentreality

This comment has been minimized.

Contributor

differentreality commented Apr 29, 2016

Photos for conference, sponsor and logding look good! 👍

I don't think we are showing a photo for Venue anymore.. Not sure if that was intended in #946

@hennevogel

This comment has been minimized.

Member

hennevogel commented Apr 29, 2016

Yeah I've seen this. That Venue doesn't degrade anymore is a bug (#974) :-)

@hennevogel

This comment has been minimized.

Member

hennevogel commented Apr 29, 2016

@differentreality so this can be merged?

@differentreality

This comment has been minimized.

Contributor

differentreality commented Apr 29, 2016

Yeap, let's do this 👍

@hennevogel hennevogel merged commit 3ce6297 into openSUSE:master Apr 29, 2016

4 checks passed

Hakiri No security warnings were found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.007%) to 84.462%
Details
omniref The Omniref review for pull request 970 was approved!
Details

@hennevogel hennevogel deleted the hennevogel:feature_cloudinary branch May 23, 2016

@nishanthvijayan

This comment has been minimized.

Contributor

nishanthvijayan commented May 24, 2016

@hennevogel Now that they are not being used shouldn't we remove fields like logo_file_size, logo_content_type, logo_updated_at from the tables conferences sponsors and events?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment