Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable find_provides and requires #14

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
2 participants
@bmwiedemann
Copy link
Member

commented Apr 3, 2019

Enable find_provides and requires
to get automatic provides instead of manual ones
like the original package did

Without this patch,
rpm -qpv --provides $rpm
differed significantly between OBS build and local osc build.

filterdiff "rpm -qpv --provides" binaries*/fwupd-1.2.3-*.x86_64.rpm
--- filter/binaries/fwupd-1.2.3-42.6.x86_64.rpm
+++ filter/binaries.nachbau/fwupd-1.2.3-42.6.x86_64.rpm
@@ -1,4 +1,3 @@
-manual: config(fwupd) = 1.2.3-42.6
 config: config(fwupd) = 1.2.3-42.6
 manual: fwupd = 1.2.3-42.6
...
-manual: libfu_plugin_altos.so()(64bit)
-manual: libfu_plugin_amt.so()(64bit)
+auto: libfu_plugin_altos.so()(64bit)
+auto: libfu_plugin_amt.so()(64bit)

Fixes part of issue #9

Enable find_provides and requires
to get automatic provides instead of manual ones
like the original package did

Without this patch,
rpm -qpv --provides $rpm
differed significantly between OBS build and local osc build.
@lcp

This comment has been minimized.

Copy link
Collaborator

commented Apr 8, 2019

Would this patch handle the customized %find_priovide scripts?

@bmwiedemann

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2019

Not sure. Do you have an example for such a package?
I checked the ones in
https://build.opensuse.org/project/show/home:bmwiedemann:reproducible:pesign
and it worked there.

@lcp

This comment has been minimized.

Copy link
Collaborator

commented Apr 9, 2019

Ok, I will try to find a package with the customized find_provide script and see how it works.

@lcp

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

I found that no user of pesign-obs-integration uses the customized find_* scripts, so maybe I just worried too much.

@lcp lcp merged commit 42b9347 into openSUSE:master Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.