New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm: properly forward dep flags #8

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
2 participants
@bmwiedemann
Member

bmwiedemann commented Sep 3, 2018

rpmds.h says:

RPMSENSE_POSTTRANS = (1 << 5),  /*!< %posttrans dependency */
RPMSENSE_PRETRANS  = (1 << 7),  /*!< Pre-transaction dependency. */
RPMSENSE_INTERP	   = (1 << 8),  /*!< Interpreter used by scriptlet. */

without this, kmp packages would differ in bit 5-8 compared to local builds
Diffs were mostly in rpm tags for /bin/sh and /bin/ldconfig

This fix was done as part of work on reproducible builds for openSUSE.

Fix was somewhat tested in https://build.opensuse.org/project/monitor/home:bmwiedemann:reproducible:pesign

pkgdiff showed for xtables-addons

comparing PROVIDES
-/bin/sh 0
-/bin/sh 1024
 /bin/sh 1280
-/bin/sh 2048
 /bin/sh 2304
 /bin/sh 288
-/bin/sh 4096
 /bin/sh 4352
 coreutils 0
rpm: properly forward dep flags
rpmds.h says:
RPMSENSE_POSTTRANS = (1 << 5),  /*!< %posttrans dependency */
RPMSENSE_PRETRANS  = (1 << 7),  /*!< Pre-transaction dependency. */
RPMSENSE_INTERP	   = (1 << 8),  /*!< Interpreter used by scriptlet. */

without this, kmp packages would differ in bit 5-8 compared to local builds
Diffs were mostly in rpm tags for /bin/sh and /bin/ldconfig

This fix was done as part of work on reproducible builds for openSUSE.

@lcp lcp merged commit efbb5c9 into openSUSE:master Sep 4, 2018

@lcp

This comment has been minimized.

Show comment
Hide comment
@lcp

lcp Sep 4, 2018

Collaborator

Thanks.

Collaborator

lcp commented Sep 4, 2018

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment