{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":196456971,"defaultBranch":"master","name":"qemu-edk2","ownerLogin":"openSUSE","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2019-07-11T19:55:53.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/623819?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1708360501.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"b8a3eec88cc74bbfe7fb389d026cc7d1d8a989c8","ref":"refs/heads/v8.2.1-factory","pushedAt":"2024-02-19T16:35:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dfaggioli","name":"Dario Faggioli","path":"/dfaggioli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1057353?s=80&v=4"},"commit":{"message":"RedfishPkg/RedfishDicovery: Remedy Redfish service discovery flow\n\nRemedy Redfish service discovery flow changes made\nin commit 8736b8fd.\n\nThe above fix creates the dependency with SMBIOS 42h record,\nwhich has a problem as SMBIOS 42h may not be created when\nRedfishDiscovery.Supported() is invoked even all of the\nrequired protocols are ready on the ControllerHandle. We can’t\nguarantee SMBIOS 42 structure will be always created before\nConnectController(). USB NIC maybe detected late and it means\nPlatformHostInterfaceBmcUsbNicLib can populate SMBIOS 42h\ninformation late as well. Calling to\nRedfishServiceGetNetworkInterface with the previous fix may\nresult in no network interface for BMC-exposed NIC as SMBIOS\n42h is not ready yet.This is the first issue.\n\nSecond, to skip the network interface when\nNetworkInterfaceGetSubnetInfo() returns a failure also has\nproblem, as the NIC may be configured via RestEx->Configure().\nThis happens after the Host interface is discovered, as at this\nmoment we have the sufficient network information to configure\nBMC-exposed NIC.\n\nBase on Redfish spec in 31.1.5.2, “EFI Redfish Client may provide\nselection UI of network interfaces for Redfish service discovery.\",\nThis means edk2 Redfish client gets all network interfaces\nthrough RedfishServiceGetNetworkInterface and choose the desired\nnetwork interface at its discretion for Redfish service.\n\nSo the fix here is:\n1. In BuildNetworkInterface(), we don’t skip any network\n interface. In RedfishServiceGetNetworkInterface, we don’t\n skip any network interface even the subnet information is not\n retrieved. We will still return all of network interfaces to\n client.\n2. In RedfishServiceAcquireService for\n EFI_REDFISH_RISCOVER_HOST_INTERFACE case, we don’t skip any\n network interface even the subnet information is not\n retrieved.\n\n3. Added some more debug information.\n\nNote: The subnet information is used for the scenario the system\nis managed by a centralized Redfish service (not on BMC), says\nthe multiple Redfish computer system instances. As it mentions\nin 31.1.5.2, Redfish client they may have to know the subnet\ninformation so they can know the network domain the NIC is\nconnected. There may have multiple subnets in the corporation\nnetwork environment. So the subnet information provides client\nan idea when they choose the network interface, so does VLAN ID.\n\nSigned-off-by: Abner Chang \nCc: Nickle Wang \nCc: Igor Kulchytskyy \nCc: Mike Maslenkin \nReviewed-by: Igor Kulchytskyy \nAcked-by: Mike Maslenkin ","shortMessageHtmlLink":"RedfishPkg/RedfishDicovery: Remedy Redfish service discovery flow"}},{"before":"0c32b776edd7296a7b54402462349a892768405f","after":"ae240bf96ba82fc08a40e275d579e59d827636d0","ref":"refs/heads/v6.2.0-sle15sp4","pushedAt":"2023-07-27T12:30:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"dfaggioli","name":"Dario Faggioli","path":"/dfaggioli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1057353?s=80&v=4"},"commit":{"message":"[openSUSE] Update submodule references\n\nSigned-off-by: Dario Faggioli ","shortMessageHtmlLink":"[openSUSE] Update submodule references"}},{"before":null,"after":"0c32b776edd7296a7b54402462349a892768405f","ref":"refs/heads/v6.2.0-sle15sp4","pushedAt":"2023-07-27T10:20:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dfaggioli","name":"Dario Faggioli","path":"/dfaggioli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1057353?s=80&v=4"},"commit":{"message":"Ignore spurious GCC 12 warning\n\nGit-commit: 0000000000000000000000000000000000000000\nReferences: bsc#1197018\n\nBuilding with GCC 12 fails producing errors. This is an example (but\nthere are others):\n\n[ 1051s] Sdk/C/LzmaEnc.c: In function 'LzmaEnc_CodeOneMemBlock':\n[ 1051s] Sdk/C/LzmaEnc.c:2641:19: error: storing the address of local\nvariable 'outStream' in '*p.rc.outStream' [-Werror=dangling-pointer=]\n[ 1051s] 2641 | p->rc.outStream = &outStream.vt;\n[ 1051s] | ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~\n[ 1051s] Sdk/C/LzmaEnc.c:2624:28: note: 'outStream' declared here\n[ 1051s] 2624 | CLzmaEnc_SeqOutStreamBuf outStream;\n[ 1051s] | ^~~~~~~~~\n[ 1051s] Sdk/C/LzmaEnc.c:2624:28: note: 'pp' declared here\n\nWhich is a false positive reported by GCC compiler:\nhttps://gcc.gnu.org/bugzilla/show_bug.cgi?id=98503\n\nWork it around by silencing the warning.\n\nSigned-off-by: Martin Liška \nSigned-off-by: Dario Faggioli ","shortMessageHtmlLink":"Ignore spurious GCC 12 warning"}},{"before":null,"after":"210bf9349346c996e69658caf25d72c60cc1a8ba","ref":"refs/heads/v7.1.0-sle15sp5","pushedAt":"2023-05-23T12:28:17.801Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dfaggioli","name":"Dario Faggioli","path":"/dfaggioli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1057353?s=80&v=4"},"commit":{"message":"[openSUSE] Basetools: Ignore spurious GCC 12 warning\n\nReferences: bsc#1197018\n\nBuilding with GCC 12 fails producing errors. This is an example (but\nthere are others):\n\n[ 1051s] Sdk/C/LzmaEnc.c: In function 'LzmaEnc_CodeOneMemBlock':\n[ 1051s] Sdk/C/LzmaEnc.c:2641:19: error: storing the address of local\nvariable 'outStream' in '*p.rc.outStream' [-Werror=dangling-pointer=]\n[ 1051s] 2641 | p->rc.outStream = &outStream.vt;\n[ 1051s] | ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~\n[ 1051s] Sdk/C/LzmaEnc.c:2624:28: note: 'outStream' declared here\n[ 1051s] 2624 | CLzmaEnc_SeqOutStreamBuf outStream;\n[ 1051s] | ^~~~~~~~~\n[ 1051s] Sdk/C/LzmaEnc.c:2624:28: note: 'pp' declared here\n\nWhich is a false positive reported by GCC compiler:\nhttps://gcc.gnu.org/bugzilla/show_bug.cgi?id=98503\n\nWork it around by silencing the warning.\n\nSigned-off-by: Martin Liška \nSigned-off-by: Dario Faggioli ","shortMessageHtmlLink":"[openSUSE] Basetools: Ignore spurious GCC 12 warning"}},{"before":"10a606f49b3f79474bf3352a4ea7fadff0c8e17a","after":"210bf9349346c996e69658caf25d72c60cc1a8ba","ref":"refs/heads/factory","pushedAt":"2023-04-26T07:44:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dfaggioli","name":"Dario Faggioli","path":"/dfaggioli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1057353?s=80&v=4"},"commit":{"message":"[openSUSE] Basetools: Ignore spurious GCC 12 warning\n\nReferences: bsc#1197018\n\nBuilding with GCC 12 fails producing errors. This is an example (but\nthere are others):\n\n[ 1051s] Sdk/C/LzmaEnc.c: In function 'LzmaEnc_CodeOneMemBlock':\n[ 1051s] Sdk/C/LzmaEnc.c:2641:19: error: storing the address of local\nvariable 'outStream' in '*p.rc.outStream' [-Werror=dangling-pointer=]\n[ 1051s] 2641 | p->rc.outStream = &outStream.vt;\n[ 1051s] | ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~\n[ 1051s] Sdk/C/LzmaEnc.c:2624:28: note: 'outStream' declared here\n[ 1051s] 2624 | CLzmaEnc_SeqOutStreamBuf outStream;\n[ 1051s] | ^~~~~~~~~\n[ 1051s] Sdk/C/LzmaEnc.c:2624:28: note: 'pp' declared here\n\nWhich is a false positive reported by GCC compiler:\nhttps://gcc.gnu.org/bugzilla/show_bug.cgi?id=98503\n\nWork it around by silencing the warning.\n\nSigned-off-by: Martin Liška \nSigned-off-by: Dario Faggioli ","shortMessageHtmlLink":"[openSUSE] Basetools: Ignore spurious GCC 12 warning"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAD_tp3hgA","startCursor":null,"endCursor":null}},"title":"Activity · openSUSE/qemu-edk2"}