Create minion_id with reproducible mtime #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this patch my tests showed, that /etc/salt/minion_id ghost file mtime varied from date.
vzhestkov
approved these changes
Apr 26, 2022
| @@ -1277,7 +1277,7 @@ install -Dpm 0755 scripts/suse/watchdog/salt-daemon-watcher %{buildroot}%{_bindi | |||
| # | |||
| ## install config files | |||
| install -Dpm 0640 conf/minion %{buildroot}%{_sysconfdir}/salt/minion | |||
| install -Dpm 0640 /dev/null %{buildroot}%{_sysconfdir}/salt/minion_id | |||
| touch -m 0640 -r conf/minion %{buildroot}%{_sysconfdir}/salt/minion_id # ghost file | |||
There was a problem hiding this comment.
So in this case it just uses the time from conf/minion, not the content. Looks reasonable.
|
@vzhestkov we can merge this PR and then we would need to create SRs ourselves. |
|
Can someone please merge then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Create
minion_idwith reproducible mtime.without this patch
my tests showed, that
/etc/salt/minion_idghost file mtime varied from date.This patch was done while working on reproducible builds for openSUSE.