Fixes incorrectly used for any* #73

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
2 participants
Member

LTe commented Jul 20, 2012

No description provided.

I think you should leave any(*) call here because there may be any number of arguments before the opions hash for some finder methods. For example, this is a valid (although unlikely) call:

User.find(1, 2, 3, 4, :conditions => { :admin => false })

Here any{1} is OK (both send_file and send_data take just 1 argument before the options) but you can write just any here (without the count).

Contributor

dmajda commented Jul 23, 2012

Please fix the issues I pointed out in a new or rebased pull request. Otherwise the code looks OK.

Member

LTe commented Jul 23, 2012

I think we should use any{1,}

Because with any* we also recognize

find(:limit => params[:input])
Contributor

dmajda commented Jul 24, 2012

@LTe Yeah, you're right.

@LTe LTe closed this Jul 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment