New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non exclusive select #81

Merged
merged 2 commits into from Jul 19, 2017

Conversation

Projects
None yet
3 participants
@nikhilgupta1211
Contributor

nikhilgupta1211 commented Jul 15, 2017

No description provided.

array_unique = (array) ->
unique_value = []
unique_value.push i for i in array when not (i in unique_value)
return unique_value

This comment has been minimized.

@bgeuken

bgeuken Jul 17, 2017

Member

There's probably some function or jquery model available for this. Did you check?

This comment has been minimized.

@nikhilgupta1211

nikhilgupta1211 Jul 17, 2017

Contributor

Sorry but I was not able to found a method to remove duplicate items in a string array :(

This comment has been minimized.

@bgeuken

bgeuken Jul 18, 2017

Member

Okay. Seems not as easy in js as I hoped.

value = []
value = users(value)
if value.length == 0 && $("input[type='checkbox']:checked").length > 0
$('#event_email_to').val('No recipients')

This comment has been minimized.

@bgeuken

bgeuken Jul 17, 2017

Member

Wrong indentation;-)

This comment has been minimized.

@nikhilgupta1211

nikhilgupta1211 Jul 17, 2017

Contributor

thanks :)

$(this).click ->
$(this).parent().removeClass('selected')
value = []
value = users(value)

This comment has been minimized.

@bgeuken

bgeuken Jul 17, 2017

Member

Seems you can remove the previous line, right?

This comment has been minimized.

@nikhilgupta1211
@bgeuken

This comment has been minimized.

Member

bgeuken commented Jul 17, 2017

The ui looks fine to me. Please check my comments regarding the code

@nikhilgupta1211

This comment has been minimized.

Contributor

nikhilgupta1211 commented Jul 17, 2017

image
image

@coveralls

This comment has been minimized.

coveralls commented Jul 17, 2017

Coverage Status

Coverage remained the same at 92.003% when pulling af331ff on nikhilgupta1211:nonexclusiveselect into c598ebb on openSUSE:master.

@openSUSE openSUSE deleted a comment from coveralls Jul 19, 2017

@openSUSE openSUSE deleted a comment from coveralls Jul 19, 2017

@openSUSE openSUSE deleted a comment from coveralls Jul 19, 2017

@openSUSE openSUSE deleted a comment from coveralls Jul 19, 2017

@bgeuken bgeuken merged commit ddb42d7 into openSUSE:master Jul 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.003%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment