New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Organizer #83

Merged
merged 2 commits into from Aug 4, 2017

Conversation

Projects
None yet
4 participants
@nikhilgupta1211
Contributor

nikhilgupta1211 commented Jul 21, 2017

rebase after #80

@nikhilgupta1211

This comment has been minimized.

Contributor

nikhilgupta1211 commented Jul 22, 2017

@ChrisBr @bgeuken the abilities are properly working now please have a look at this :)

@nikhilgupta1211

This comment has been minimized.

Contributor

nikhilgupta1211 commented Jul 22, 2017

event_organizer#index
image

event_organizer#new
image

@coveralls

This comment has been minimized.

coveralls commented Jul 24, 2017

Coverage Status

Coverage increased (+0.1%) to 92.151% when pulling ab1a9a0 on nikhilgupta1211:eorganizer into c6bb8b1 on openSUSE:master.

@openSUSE openSUSE deleted a comment from coveralls Jul 24, 2017

@openSUSE openSUSE deleted a comment from coveralls Jul 24, 2017

@openSUSE openSUSE deleted a comment from coveralls Jul 24, 2017

@openSUSE openSUSE deleted a comment from coveralls Jul 24, 2017

@openSUSE openSUSE deleted a comment from coveralls Jul 24, 2017

@openSUSE openSUSE deleted a comment from coveralls Jul 24, 2017

@openSUSE openSUSE deleted a comment from coveralls Jul 24, 2017

@openSUSE openSUSE deleted a comment from coveralls Jul 24, 2017

@openSUSE openSUSE deleted a comment from coveralls Jul 24, 2017

@bgeuken

This comment has been minimized.

Member

bgeuken commented Jul 24, 2017

UI looks good to me.

@@ -3,6 +3,26 @@
feature 'Email Events', '' do
fixtures :all
scenario 'When logged in as a requester' do

This comment has been minimized.

@ChrisBr

ChrisBr Jul 25, 2017

Member

Filename is wrong: s/spec/features/event_email.spec.rb/spec/features/event_email_spec.rb/

This comment has been minimized.

@nikhilgupta1211

nikhilgupta1211 Jul 26, 2017

Contributor

Fixed in #85

autocomplete :user, :email
belongs_to :event
actions :all, except: [:show, :edit, :update]

This comment has been minimized.

@bgeuken

bgeuken Jul 26, 2017

Member

@nikhilgupta1211 Are we doing any authorization for this controller?

@coveralls

This comment has been minimized.

coveralls commented Jul 26, 2017

Coverage Status

Coverage increased (+0.1%) to 92.151% when pulling f606483 on nikhilgupta1211:eorganizer into c6bb8b1 on openSUSE:master.

@coveralls

This comment has been minimized.

coveralls commented Jul 27, 2017

Coverage Status

Coverage increased (+0.1%) to 92.151% when pulling 09a7357 on nikhilgupta1211:eorganizer into c6bb8b1 on openSUSE:master.

@coveralls

This comment has been minimized.

coveralls commented Jul 28, 2017

Coverage Status

Coverage increased (+0.1%) to 92.632% when pulling bc5ce2b on nikhilgupta1211:eorganizer into d9364af on openSUSE:master.

@coveralls

This comment has been minimized.

coveralls commented Jul 28, 2017

Coverage Status

Coverage increased (+0.1%) to 92.632% when pulling 121610a on nikhilgupta1211:eorganizer into d9364af on openSUSE:master.

@@ -2,6 +2,7 @@
require 'cancan/matchers'
# require 'ruby-debug'
# rubocop:disable BlockLength

This comment has been minimized.

@bgeuken

bgeuken Aug 3, 2017

Member

Please squash this commit into the one that introduced the rubocop failure

This comment has been minimized.

@nikhilgupta1211

nikhilgupta1211 Aug 3, 2017

Contributor

yes ok :)

nikhilgupta1211 added some commits Jul 22, 2017

Created event organizer model, view and controller
Added the functionality of autocomplete
Added tests for event organizer and event email ability
Also updated the ability specs for the event organizer
Disabled rubocop BlockLength for the administrative ability test block
@bgeuken

bgeuken approved these changes Aug 3, 2017

@coveralls

This comment has been minimized.

coveralls commented Aug 3, 2017

Coverage Status

Coverage increased (+0.1%) to 92.641% when pulling 73a9d9d on nikhilgupta1211:eorganizer into b54f769 on openSUSE:master.

spec file name has been fixed now

@bgeuken bgeuken merged commit fc76ae1 into openSUSE:master Aug 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 92.641%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment