New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to view the participants page for an event organizer #91

Merged
merged 2 commits into from Aug 14, 2017

Conversation

Projects
None yet
4 participants
@nikhilgupta1211
Contributor

nikhilgupta1211 commented Aug 8, 2017

No description provided.

@coveralls

This comment has been minimized.

coveralls commented Aug 8, 2017

Coverage Status

Coverage increased (+0.009%) to 92.65% when pulling e9a77a4 on nikhilgupta1211:partiorg into fc76ae1 on openSUSE:master.

@@ -65,6 +65,9 @@ def initialize(user)
# Events
can [:read, :create], Event
can [:participants], Event do |r|
user.events.exists?(r.id)

This comment has been minimized.

@ChrisBr

ChrisBr Aug 9, 2017

Member

I think the association events has a wrong name because it is not clear that the user is organizer!

@coveralls

This comment has been minimized.

coveralls commented Aug 9, 2017

Coverage Status

Coverage increased (+0.01%) to 92.654% when pulling d9659f7 on nikhilgupta1211:partiorg into fc76ae1 on openSUSE:master.

@coveralls

This comment has been minimized.

coveralls commented Aug 9, 2017

Coverage Status

Coverage increased (+0.01%) to 92.654% when pulling d9659f7 on nikhilgupta1211:partiorg into fc76ae1 on openSUSE:master.

@coveralls

This comment has been minimized.

coveralls commented Aug 9, 2017

Coverage Status

Coverage increased (+0.01%) to 92.654% when pulling eff721e on nikhilgupta1211:partiorg into fc76ae1 on openSUSE:master.

@coveralls

This comment has been minimized.

coveralls commented Aug 9, 2017

Coverage Status

Coverage increased (+0.01%) to 92.654% when pulling f159171 on nikhilgupta1211:partiorg into fc76ae1 on openSUSE:master.

it { should be_able_to(:read, requests(:wedge_for_party)) }
end
context 'is not a event organizer' do

This comment has been minimized.

@bgeuken

bgeuken Aug 10, 2017

Member

I am nitpicking, 'is not an event organizer';-)

This comment has been minimized.

@nikhilgupta1211

nikhilgupta1211 Aug 10, 2017

Contributor

fixed it :)

@coveralls

This comment has been minimized.

coveralls commented Aug 10, 2017

Coverage Status

Coverage increased (+0.01%) to 92.654% when pulling bbf313d on nikhilgupta1211:partiorg into fc76ae1 on openSUSE:master.

@@ -65,13 +65,18 @@ def initialize(user)
# Events
can [:read, :create], Event
can [:participants], Event do |r|
user.organizing_events.exists?(r.id)

This comment has been minimized.

@ChrisBr

ChrisBr Aug 14, 2017

Member

Is this working? What is r?

This comment has been minimized.

@nikhilgupta1211

nikhilgupta1211 Aug 14, 2017

Contributor

Yes, it is working. r is for event actually we are using r for many other names so used here also, changing it :)

@coveralls

This comment has been minimized.

coveralls commented Aug 14, 2017

Coverage Status

Coverage decreased (-1.5%) to 91.171% when pulling 03959e0 on nikhilgupta1211:partiorg into bc97987 on openSUSE:master.

Added participants view ability for an event organizer
Also added the permission to read travel_sponsorships for an event organizer
@ChrisBr

LGTM

@coveralls

This comment has been minimized.

coveralls commented Aug 14, 2017

Coverage Status

Coverage increased (+0.01%) to 92.717% when pulling 6317eca on nikhilgupta1211:partiorg into 49da543 on openSUSE:master.

@ChrisBr ChrisBr merged commit c12fe46 into openSUSE:master Aug 14, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 92.717%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment