Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIR should conform to XSD #20

Closed
vasile opened this issue May 7, 2024 · 5 comments
Closed

LIR should conform to XSD #20

vasile opened this issue May 7, 2024 · 5 comments
Assignees
Labels
Blocker Is blocking an upcoming release prio:HIGH Highest priority

Comments

@vasile
Copy link
Member

vasile commented May 7, 2024

Follow up from #6

OJP 2.0 LIR request returns <Place> entries without <GeoPosition> or <Name> which is breaking the XSD schema
https://vdvde.github.io/OJP/develop/index.html#PlaceStructure

Example request / response

https://gist.github.com/vasile/cce1de006e0c4b910bcea106672bfbb5#file-ojp_geoposition_issue-xml-L40-L50

<Place>
  <TopographicPlace>
    <TopographicPlaceCode>23016216:1</TopographicPlaceCode>
    <TopographicPlaceName>
      <Text xml:lang="de">Hof (Rorschacherberg)</Text>
    </TopographicPlaceName>
  </TopographicPlace>
  <Name>
    <Text xml:lang="de">Hof (Rorschacherberg)</Text>
  </Name>
</Place>
@vasile vasile added the Bug Something isn't working label May 7, 2024
@vasile
Copy link
Member Author

vasile commented May 7, 2024

@TO-mdv OJP 2.0 LIR response should not return such entries

  • either they should be discarded from the response
  • or to be discarded at the import time

@vasile
Copy link
Member Author

vasile commented May 21, 2024

@TO-mdv - please follow-up with a resolution plan here

@TO-mdv
Copy link

TO-mdv commented May 21, 2024

Remove Stops without Coordinates, TO create Story

@vasile vasile changed the title OJP 2.0 LIR should conform to XSD LIR should conform to XSD May 21, 2024
@vasile vasile added prio:HIGH Highest priority Blocker Is blocking an upcoming release labels May 22, 2024
@TO-mdv
Copy link

TO-mdv commented May 22, 2024

SH-2978 OJP2.0 LIR Objekte ohne Koordinaten herausfiltern -> LIR-1j_SP_LocationName_keine Koordianten

@TO-mdv TO-mdv closed this as completed by moving to Release INT in OJP 2.0 Backend Issues May 22, 2024
@TO-mdv
Copy link

TO-mdv commented May 22, 2024

Released on INT
Release PROD 29.5.2024

@TO-mdv TO-mdv removed the Bug Something isn't working label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Is blocking an upcoming release prio:HIGH Highest priority
Projects
Archived in project
Development

No branches or pull requests

2 participants