TR - Footpath leg returned as TimedLeg

[vasile]

Request

/POST https://odpch-api.clients.liip.ch/ojp20-beta

<OJP xmlns:siri="http://www.siri.org.uk/siri" version="2.0"
  xmlns="http://www.vdv.de/ojp"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <OJPRequest>
    <siri:ServiceRequest>
      <siri:RequestTimestamp>2024-01-16T11:26:01.697Z</siri:RequestTimestamp>  
      <siri:RequestorRef>OJP_SDK_v0.9.24</siri:RequestorRef>
      <OJPTripRequest>
        <siri:RequestTimestamp>2024-01-16T11:26:01.697Z</siri:RequestTimestamp>
        <Origin>
          <PlaceRef>
            <StopPlaceRef>8507099</StopPlaceRef>
            <Name>
              <Text>Gurten</Text>
            </Name>
          </PlaceRef>
          <DepArrTime>2024-05-14T16:10:00.373Z</DepArrTime>
        </Origin>
        <Destination>
          <PlaceRef>
            <StopPlaceRef>8505069</StopPlaceRef>
            <Name>
              <Text>Rigi Kulm</Text>
            </Name>
          </PlaceRef>
        </Destination>
        <Params>
          <NumberOfResultsBefore>0</NumberOfResultsBefore>
          <NumberOfResultsAfter>5</NumberOfResultsAfter>
          <IncludeTrackSections>true</IncludeTrackSections>
          <IncludeLegProjection>true</IncludeLegProjection>
          <IncludeTurnDescription>true</IncludeTurnDescription>
          <IncludeIntermediateStops>true</IncludeIntermediateStops>
        </Params>
      </OJPTripRequest>
    </siri:ServiceRequest>
  </OJPRequest>
</OJP>

returns https://gist.github.com/vasile/c7328ece784a7495d98fd85bb0ebc980

For transfer a TimedLeg is returned, TransferLeg is expected

....
<TimedLeg>
    <LegBoard>
        <siri:StopPointRef>8507097</siri:StopPointRef>
        <StopPointName>
            <Text xml:lang="de">Wabern (Gurtenbahn)</Text>
        </StopPointName>
        <NameSuffix>
            <Text xml:lang="de">NO_DATA</Text>
        </NameSuffix>
        <ServiceDeparture>
            <TimetabledTime>2024-05-15T03:34:00Z</TimetabledTime>
        </ServiceDeparture>
        <Order>1</Order>
    </LegBoard>
    <LegAlight>
        <siri:StopPointRef>ch:1:sloid:7078:0:568472</siri:StopPointRef>
        <StopPointName>
            <Text xml:lang="de">Wabern bei Bern</Text>
        </StopPointName>
        <NameSuffix>
            <Text xml:lang="de">NO_DATA</Text>
        </NameSuffix>
        <ServiceArrival>
            <TimetabledTime>2024-05-15T03:38:00Z</TimetabledTime>
        </ServiceArrival>
        <Order>2</Order>
    </LegAlight>
    <Service>
        <Mode>
            <PtMode>undefinedModeOfTransport</PtMode>
            <Name>
                <Text xml:lang="de">Fussweg</Text>
            </Name>
        </Mode>
        <ConventionalModeOfOperation>scheduled</ConventionalModeOfOperation>
        <TrainNumber />
        <siri:LineRef>::_x0020_</siri:LineRef>
        <siri:OperatorRef></siri:OperatorRef>
        <ProductCategory>
            <Name>
                <Text xml:lang="de">Fussweg</Text>
            </Name>
            <ProductCategoryRef>-1</ProductCategoryRef>
        </ProductCategory>
        <siri:DirectionRef>_x0020_</siri:DirectionRef>
        <OperatingDayRef>2024-05-15</OperatingDayRef>
        <JourneyRef />
    </Service>
    <LegTrack>
        <TrackSection>
            <TrackSectionStart>
                <siri:StopPointRef>8507097</siri:StopPointRef>
                <Name>
                    <Text xml:lang="de">Wabern (Gurtenbahn)</Text>
                </Name>
            </TrackSectionStart>
            <TrackSectionEnd>
                <siri:StopPointRef>8507078</siri:StopPointRef>
                <Name>
                    <Text xml:lang="de">Wabern bei Bern</Text>
                </Name>
            </TrackSectionEnd>
            <Duration>PT4M</Duration>
        </TrackSection>
    </LegTrack>
</TimedLeg>
...

[TO-mdv]

Created a bug SH-2947 OJP2.0 Footpath leg returned as TimedLeg -> TR-1s_Footpath as TransferLeg

[vasile]

We need to know when will be fixed because is affecting the TR implementation, for instance PublishedServiceName is expected in the TimedLeg - for now on we've declared it optional

https://github.com/openTdataCH/ojp-ios/blob/feature/trips/Sources/OJP/Models/OJPv2%2BTrip.swift#L347

[TO-mdv]

Currently, it's planned after all the LIR issues and disruption messages (AddInfo).
So I guess should be fixed around 7. June. But if you would set the priority higher for this, we can check with Christoph Lucas

[TO-mdv]

@vasile I just talked to Christoph and Andreas. This sould be a small issue, so we will do it before disruption messages. Should be fixed by next week

[TO-mdv]

resolved on TEST/INT

[TO-mdv]

Released on INT
Release PROD 27.5.2024