Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TR TimedLeg is missing DestinationText #38

Closed
vasile opened this issue May 27, 2024 · 7 comments
Closed

TR TimedLeg is missing DestinationText #38

vasile opened this issue May 27, 2024 · 7 comments
Assignees
Labels
prio:MEDIUM Default priority Question Further information is requested

Comments

@vasile
Copy link
Member

vasile commented May 27, 2024

At the moment there is no <DestinationText> (and <DestinationStopPointRef>)

It is present in v1, any ETA when will be available in v2?

<ojp:Service>
    <ojp:OperatingDayRef>2024-05-17</ojp:OperatingDayRef>
    <ojp:JourneyRef>ch:1:sjyid:100001:964-001</ojp:JourneyRef>
    <siri:LineRef>ojp:91006:H</siri:LineRef>
    <siri:DirectionRef>R</siri:DirectionRef>
    <ojp:Mode>
        <ojp:PtMode>rail</ojp:PtMode>
        <siri:RailSubmode>interRegionalRailService</siri:RailSubmode>
        <ojp:Name>
            <ojp:Text xml:lang="de">Zug</ojp:Text>
        </ojp:Name>
        <ojp:ShortName>
            <ojp:Text xml:lang="de">IC</ojp:Text>
        </ojp:ShortName>
    </ojp:Mode>
    <ojp:PublishedLineName>
        <ojp:Text xml:lang="de">IC6</ojp:Text>
    </ojp:PublishedLineName>
    <ojp:OperatorRef>ojp:11</ojp:OperatorRef>
    <ojp:DestinationStopPointRef>8500010</ojp:DestinationStopPointRef>
    <ojp:DestinationText>
        <ojp:Text xml:lang="de">Basel SBB</ojp:Text>
    </ojp:DestinationText>
</ojp:Service>
@vasile vasile changed the title TR TimedLeg with TR TimedLeg is missing DestinationText May 27, 2024
@vasile vasile added enhancement Question Further information is requested labels May 27, 2024
@r3to r3to added the prio:MEDIUM Default priority label May 27, 2024
@r3to
Copy link
Contributor

r3to commented Jun 10, 2024

DestinationText is optional on XSD (but required for our use case)

OriginText is mandatory according to the XSD but missing in the response

https://vdvde.github.io/OJP/develop/index.html#ServiceGroup

@TO-mdv TO-mdv assigned herlitze and unassigned TO-mdv Jun 19, 2024
@TO-mdv
Copy link

TO-mdv commented Jun 19, 2024

SH-3136 OJP2.0 TR Ausgabe und ojp:DestinationStopPointRef und </ojp:DestinationText>

@TO-mdv
Copy link

TO-mdv commented Jun 21, 2024

Release on PROD on 27.6.2024

@r3to
Copy link
Contributor

r3to commented Jul 2, 2024

I assumed, that DestinationText refers to the last stop of the service (where the service terminates) and not the last stop of the parent trip (LegAlight).

So for a trip from Berne to Zurich with IC 8 I expected DestinationText to be "Romanshorn" and not "Zürich HB" and OriginText to be "Brig" instead of "Bern"

@TO-mdv did I misunderstand the documentation or is it currently returning the wrong information?

Edit: I've just double checked with https://www.öv-info.ch/de On those responses, DestinationText is referring to the Service. So it looks like an error on OJP2.0.

@vasile
Copy link
Member Author

vasile commented Jul 2, 2024

@r3to can also confirm is a bug, in OJP 1.0 you get Romanshorn for an IC8 service

<ojp:Service>
    <ojp:OperatingDayRef>2024-07-02</ojp:OperatingDayRef>
    <ojp:JourneyRef>ch:1:sjyid:100001:823-002</ojp:JourneyRef>
    <siri:LineRef>ojp:91081:A</siri:LineRef>
    <siri:DirectionRef>H</siri:DirectionRef>
....
    <ojp:PublishedLineName>
        <ojp:Text xml:lang="de">IC81</ojp:Text>
    </ojp:PublishedLineName>
    <ojp:OperatorRef>ojp:11</ojp:OperatorRef>
    <ojp:DestinationStopPointRef>8506121</ojp:DestinationStopPointRef>
    <ojp:DestinationText>
        <ojp:Text xml:lang="de">Romanshorn</ojp:Text>
    </ojp:DestinationText>
</ojp:Service>

@TO-mdv
Copy link

TO-mdv commented Jul 3, 2024

Yes, you're both right. I create a bug for this issue. Thanks!

@TO-mdv
Copy link

TO-mdv commented Jul 11, 2024

Fixed on INT, Release on PROD 25.7.2024

<DestinationStopPointRef>8506121</DestinationStopPointRef>
<OriginText>
    <Text xml:lang="de">n/a</Text>
</OriginText>
<DestinationText>
    <Text xml:lang="de">Romanshorn</Text>
</DestinationText>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio:MEDIUM Default priority Question Further information is requested
Projects
Archived in project
Development

No branches or pull requests

4 participants