Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIR "Ba" + Type=stop return no entries #8

Closed
vasile opened this issue Apr 20, 2024 · 8 comments
Closed

LIR "Ba" + Type=stop return no entries #8

vasile opened this issue Apr 20, 2024 · 8 comments
Assignees
Labels
Blocker Is blocking an upcoming release data-quality Cases where the data is not as expected prio:HIGH Highest priority

Comments

@vasile
Copy link
Member

vasile commented Apr 20, 2024

https://tools.odpch.ch/ojp-api-explorer-v2/?gist=55350e671acfddff976e8c6c54306b3b

Expected are Baden, Basel SBB, etc

<OJP xmlns:siri="http://www.siri.org.uk/siri" xmlns="http://www.vdv.de/ojp" version="2.0">
  <OJPResponse>
    <siri:ServiceDelivery>
      <siri:ResponseTimestamp>2024-04-20T22:14:19.7657336+00:00</siri:ResponseTimestamp>
      <siri:ProducerRef>MENTZ</siri:ProducerRef>
      <OJPLocationInformationDelivery>
        <siri:ResponseTimestamp>2024-04-20T22:14:19.7657383+00:00</siri:ResponseTimestamp>
        <siri:RequestMessageRef>677460f9-50cb-45f9-bcf5-a1524e32444a</siri:RequestMessageRef>
        <siri:DefaultLanguage>de</siri:DefaultLanguage>
        <CalcTime>3</CalcTime>
      </OJPLocationInformationDelivery>
    </siri:ServiceDelivery>
  </OJPResponse>
</OJP>

Request
/POST https://api.opentransportdata.swiss/ojp20
XML: https://gist.github.com/vasile/55350e671acfddff976e8c6c54306b3b

@vasile vasile added Bug Something isn't working data-quality Cases where the data is not as expected labels Apr 20, 2024
@AndreasAtSBB
Copy link

AndreasAtSBB commented Apr 30, 2024

Just checked what reference is showing bls.ch:
image
Nothing!

Probably we should try then to use with 3 letters:
image
I think that's an acceptable result!

@TO-mdv
Copy link

TO-mdv commented May 15, 2024

Search should also work for 2 letters. It works without restriction, but as soon a filter like stop or address is set, it's not working anymore. We will fix that: SH-2931 OJP2.0 LIR liefert keine Ergebnisse für "Ba" -> LIR-1g_SP_LocationName_Stop mit 2 Buchstaben

@vasile vasile changed the title OJP 2.0 LIR "Ba" + Type=stop return no entries LIR "Ba" + Type=stop return no entries May 21, 2024
@vasile vasile added prio:HIGH Highest priority Blocker Is blocking an upcoming release labels May 22, 2024
@TO-mdv TO-mdv removed the Bug Something isn't working label May 23, 2024
@TO-mdv
Copy link

TO-mdv commented May 23, 2024

@vasile also here, is there really a Usecase to search by 2 letters and you expect the object you are looking for? There are too many results for stops and address as well.
sbb.ch gives you a response, but they are not really useful in my opinion:

Image

So I would propose to close this issue and expect the use to enter more details.

@vasile
Copy link
Member Author

vasile commented May 23, 2024

Cant the system use a different smaller index search for 2-letter search terms? I.e. top stops in Switzerland.
If we exclude then also people travelling to Au (ZH or SG) will be affected ;)

@TO-mdv
Copy link

TO-mdv commented May 23, 2024

The problem isn't the 2-letter search, in some cirumstances also a 2-letter search works, example "au":

  1. Aarau STOP
  2. Aurec STOP
  3. Autun STOP
  4. Aubiat STOP
  5. Auboué STOP
  6. Auggen STOP
  7. Altnau STOP
  8. Auxonne STOP
  9. Au ZH STOP
  10. Au SG STOP

The problem is effective with search strings that would return too many results, like it is for "ba".

@vasile
Copy link
Member Author

vasile commented May 24, 2024

Hi @TO-mdv , happy with wontfix for now but would be nice if we can revisit later on. Closing

@vasile vasile closed this as completed May 24, 2024
@vasile
Copy link
Member Author

vasile commented May 24, 2024

For future analyse, BLS Mobile (Hafas backend) is returning meaningful results, lets park it somewhere else

@vasile vasile reopened this May 24, 2024
@vasile vasile closed this as completed by moving to Release Candidate in OJP 2.0 Backend Issues May 24, 2024
@vasile
Copy link
Member Author

vasile commented May 24, 2024

Closing again the actual issue - opened #37 for further discussions on 2-letter search queries

@TO-mdv TO-mdv self-assigned this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Is blocking an upcoming release data-quality Cases where the data is not as expected prio:HIGH Highest priority
Projects
Archived in project
Development

No branches or pull requests

3 participants