Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared behaviours #38

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Shared behaviours #38

merged 1 commit into from
Feb 27, 2020

Conversation

ylt
Copy link
Member

@ylt ylt commented Feb 27, 2020

Point 5 on #34

"Generalise some of C1, C2 tests etc to provide shared examples that can be reused across shared test suites."

@ylt ylt requested a review from thtg88 February 27, 2020 12:44
@ylt ylt changed the base branch from master to validation-error-handling February 27, 2020 12:44
thtg88
thtg88 approved these changes Feb 27, 2020
View reviewed changes
Copy link

@thtg88 thtg88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! ✅

@ylt ylt mentioned this pull request Feb 27, 2020
Closed
@ylt ylt changed the base branch from validation-error-handling to master February 27, 2020 15:49
@ylt ylt merged commit 84c848a into master Feb 27, 2020
@nickevansuk nickevansuk deleted the shared-behaviours branch May 12, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thtg88 thtg88 thtg88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ylt @thtg88