Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed source URL slightly for us/ny/city_of_new_york #4576

Merged
merged 1 commit into from Jun 20, 2019

Conversation

Projects
None yet
3 participants
@MiniCodeMonkey
Copy link
Contributor

commented Jun 20, 2019

Using the "original" format instead of "shapefile" as shapefile appears to synchronously convert the data before it can be downloaded. I suspect that this leads to data corruption and/or timeouts.

The "original" format is already a shape file so the extra data conversion is completely unnecessary.

Note: This change was prompted by the fact that this source started outputting significantly less addresses even though the source data does not have less records

https://results.openaddresses.io/sources/us/ny/city_of_new_york
Screen Shot 2019-06-20 at 12 26 54 PM

@openaddresses-bot

This comment has been minimized.

@migurski

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

Weird, but it brings the number back up to 959k features!

@migurski migurski merged commit 4a0ea94 into openaddresses:master Jun 20, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
openaddresses/hooked Succeeded on sources/us/ny/city_of_new_york.json
Details
@MiniCodeMonkey

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

Weird indeed. It'll probably also solve some of the timeout issues that the source has seen in the past, just because their server doesn't have to do that "just in time" transformation of the whole dataset.

@MiniCodeMonkey MiniCodeMonkey deleted the MiniCodeMonkey:patch-20 branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.