{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":364443,"defaultBranch":"master","name":"openafs","ownerLogin":"openafs","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2009-11-07T15:36:35.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/150141?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1711228964.0","currentOid":""},"activityList":{"items":[{"before":"2d980aaef7a7e0c874ca21a988ba5cf710151302","after":"236cb51b833d3caaa3d5dd5ee303b4f8a8074d7c","ref":"refs/heads/master","pushedAt":"2024-05-23T21:57:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"rx: Cleanup and build src/rx/test\n\nWe have several programs in src/rx/test that are not built, and have\nbitrotted as a result. Clean them up so they can build again, and\nmake them all build by default.\n\nSome pieces depend on higher-level libraries (libafsrpc) that depend\non rx, so we cannot build all of these during 'make rx'. So create a\nnew top-level make target, 'rx_test', that just builds the test\nprograms.\n\nRemove testqueue.c instead of fixing it, since it just tests the old\nrx queue implementation, and we already have tests for the newer\nopr_queue.\n\nRemove some obsolete references to rxperf/th_rxperf in here; rxperf\nhas lived in src/tools/ for quite some time.\n\nChange-Id: I8b8b2c0813531ef185d95f4d6fdce6bc69320b80\nReviewed-on: https://gerrit.openafs.org/14749\nTested-by: BuildBot \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"rx: Cleanup and build src/rx/test"}},{"before":"95e67f9c3e6e605da07081b9521ed2eaa2add648","after":"de7bc4890e4368b88f20e15a7d795fc1c54cef29","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-23T21:23:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"Linux-6.9: file_lock mbrs moved to file_lock_core\n\nIn the Linux 6.9 commit:\n 'filelock: split common fields into struct file_lock_core' (a69ce85ec9)\nseveral fields were relocated into a new structure, file_lock_core,\nwhich was added as a member the file_lock structure. The names where\nchanged (fl_x to flc_x).\n\nAdd a configure test to determine if the new members (flc_type, flc_pid,\nand flc_flags) are available as part of the file_lock_core structure.\n\nAdd static inline getter/setter routines to handle accessing the\nflc_type or flc_pid members in the file_lock_core structure, or the\nfl_type, fl_pid members in the file_lock structure as appropriate. Add\nstatic inline function to clear FL_SLEEP in the flc_flag in the\nfile_lock_core structure or the fl_flag in the file_lock structure as\nappropriate.\n\nMinor surrounding white space cleanup.\n\nReviewed-on: https://gerrit.openafs.org/15708\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 9937cce3f35f4e3aad0802189457bf16b84d7ab4)\n\nChange-Id: I51343e1c2e360b68eabe2cc4069c25948b6c0729\nReviewed-on: https://gerrit.openafs.org/15739\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"Linux-6.9: file_lock mbrs moved to file_lock_core"}},{"before":"4fc27548be88947ef58e2a3a3654a08ec6c334d9","after":"95e67f9c3e6e605da07081b9521ed2eaa2add648","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-19T22:04:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"tests: rx/perf wait for server init before client\n\nThe rx/perf test can occasionally fail due to the rxperf server not\nbeing fully initialized before the client started. This can cause test\nerrors, even without changes to the rx code.\n\n C_TAP_VERBOSE=1 make check TESTS=\"rx/perf\"\n ...\n rx/perf\n\n 1..4\n ok 1 - Started rxperf server\n not ok 2 - single threaded client ran successfully\n RPC: threads\t30, times\t1, write bytes\t1048576, read bytes...\n ok 3 - multi threaded client ran succesfully\n ok 4 - Server exited succesfully\n FAILED 2 (exit status 1)\n\nAdd a routine that waits for the rx_perf server to become available.\nLoop several times trying the connection via the rx_perf client, with\na short delay between retries. If the connection cannot be established,\nfail the test.\n\nClean up trailing whitespace on a couple of lines.\n\nNote: This failure was observed in an OpenAFS buildbot worker that\nincluded a make tests, and which would occasionally fail when there was\nno rx related code changes. The intermittent failure could be duplicated\non a slower virtual test system, but would not fail on a faster system.\n\nThanks to mmeffie@sinenomine.net for the 'wait_for_server' contribution.\n\nReviewed-on: https://gerrit.openafs.org/15676\nTested-by: BuildBot \nReviewed-by: Benjamin Kaduk \nReviewed-by: Andrew Deason \n(cherry picked from commit 6ace773fdcff0486663a0cc4381d7b6ce2352c04)\n\nChange-Id: I75c6cd1e4e724d4803b62e2f74e5307cb8fcb14d\nReviewed-on: https://gerrit.openafs.org/15736\nReviewed-by: Michael Meffie \nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"tests: rx/perf wait for server init before client"}},{"before":"dfb6b53a6802e90f6bc2cd3cd39da467ce8e4488","after":"4fc27548be88947ef58e2a3a3654a08ec6c334d9","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-16T17:00:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"rxperf: Add -o option to rxperf client\n\nAdd the -o (output) option to the rxperf client specify the output file.\n\nIf not specified, the output is written to stdout, as before.\n\nReviewed-on: https://gerrit.openafs.org/15731\nTested-by: BuildBot \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit e6bc50524e1bde199f6643d9784fe331577bee90)\n\nChange-Id: I94a2f43c70f9cb5236c3ab4c5d2de66906eb68b3\nReviewed-on: https://gerrit.openafs.org/15735\nReviewed-by: Michael Meffie \nReviewed-by: Andrew Deason \nTested-by: Andrew Deason \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"rxperf: Add -o option to rxperf client"}},{"before":"d1a42401fddc51bd2f16da39dfebe0f60fc670ad","after":"dfb6b53a6802e90f6bc2cd3cd39da467ce8e4488","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-16T16:44:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"Linux: Define afs_thread_wrapper() as static\n\nWhen building against a Linux 6.8 kernel, functions that are missing\nprototypes or declarations are flagged.\n\nWe can add the static attribute to functions that are not referenced\noutside of the file that implements them to avoid having these functions\nflagged by the compiler.\n\nThese functions are flagged due to missing prototypes when building\nagainst a Linux 6.8 kernel (which sets the -Wmissing-declarations and\n-Wmissing-prototypes compiler flags as default). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nWhen building against a kernel with CONFIG_WERROR=y, the build fails.\n\nThis is an openafs-1.8.x specific commit.\n\nThe function afs_thread_wrapper() in LINUX/osi_misc.c on the master\nbranch was changed to a static function with commit:\n 'afs: Drop GLOCK for various Rx calls' (d5e1428a3b)\nHowever this is a larger change than needed to fix the build problem and\nthe commit could have a significant impact for 1.8.x since it is\nchanging rx locking. To avoid introducing such a change, just change\nthe afs_thread_wrapper() to static as a 1.8.x specific commit.\n\nThere are no functional changes in this commit.\n\nChange-Id: I4edc61e6a4989c16ccf41b935e205dbf209bf2a5\nReviewed-on: https://gerrit.openafs.org/15727\nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nTested-by: BuildBot \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"Linux: Define afs_thread_wrapper() as static"}},{"before":"7b4802efaf29ef76969c8b931a31e93dd4fbb000","after":"d1a42401fddc51bd2f16da39dfebe0f60fc670ad","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-16T16:38:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"Linux: Remove weak attribute for key_type_keyring\n\nThe reference to the Linux symbol key_type_keyring uses a weak\nattribute to assist in determining if the symbol is exported. This\nmethod was introduced in commit: 'keyring-updated-20080310' (b7fb842b1c)\nas a way to detect if the symbol was exported by the Linux kernel. A\nlater commit: 'linux-keyring-export-check-20090701' (4ca66112c2)\nintroduced an autoconf test that eliminated the need for using the weak\nattribute, but the commit did not remove the attribute.\n\nOn a Debian-12 system on ARM64 the use of the weak attribute in this\ncase causes an error when loading the kernel module:\n \"ERROR: could not insert 'openafs': Exec format error\".\nThe error is due to the Linux module loader not supporting the\nrelocation entry type in the openafs kernel module for the\nkey_type_keyring. Further investigation showed that this problem could\noccur with gcc-12 on a ARM64 system (see below for additional\ninformation).\n\nThe code in osi_groups.c uses a pointer, __key_type_keyring, to the\nkey_type_keyring. When this symbol is exported by the Linux kernel, the\nloader would resolve the address and __key_type_keyring would contain\nthe address. If the key_type_keyring symbol was not exported,\n__key_type_keyring would be set to NULL (due to the weak attribute\nassociated with key_type_keyring).\n\nRemove the weak attribute for key_type_keyring when the configure\ntest, introduced in the 4ca66112c2 commit, determines that the symbol\nis exported (EXPORTED_KEY_TYPE_KEYRING is defined). When the symbol\nisn't exported (pre Linux 2.6.22), just set the pointer,\n__key_type_keyring to NULL.\n\nNOTE:\n\nThe load error was reported on the openafs IRC channel by \"clarkb\"\n\nThe problem of loading the openafs kernel module was also observed\non a NixOS system as well, and is described in the NixOS ticket\n\n https://github.com/NixOS/nixpkgs/issues/284501\n\nA Debian-11 system did not have a problem loading the openafs kernel\nmodule. Investigation of the differences between Debian-11 and Debian-12\nshowed that the problem is due to a series of fixes in the toolchain\n(in particular gcc-12) to address 'Cortex-A53 erratum #843419', which\ndeals with how the ARM64 ADRP instruction is used. With gcc-12, the\ncode generated uses a R_AARCH64_ADR_GOT for this particular case (which\nisn't supported by the Linux kernel module loader). Gcc-11 created a\nR_AARCH64_ABS64 relocation entry type for the symbol.\n\nReviewed-on: https://gerrit.openafs.org/15668\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Mark Vitale \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 2f260825b96b76556aba82fc364c841357a23a7d)\n\nChange-Id: Ifce08cb01f0b642ee9c2d90480b8a1766dfc52ff\nReviewed-on: https://gerrit.openafs.org/15728\nTested-by: BuildBot \nReviewed-by: Michael Meffie \nReviewed-by: Andrew Deason \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"Linux: Remove weak attribute for key_type_keyring"}},{"before":"6333fae573f8a7b7656e9c1b05d445a37b951b88","after":"7b4802efaf29ef76969c8b931a31e93dd4fbb000","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-16T16:31:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"Linux 6.8: Use roken's strlcpy() in kernel module\n\nThe Linux 6.8 commit 'string: Remove strlcpy()' (d26270061a) removed the\nthe strlcpy function from the Linux kernel. The replacement function,\nstrscpy(), cannot be used as a drop-in replacement as its currently a\nLinux kernel specific function and there are differences in the returned\nvalue.\n\nWe can use roken's strlcpy() (provided in roken/strlcpy.c).\n\nCreate a configure test to that defines its own strlcpy() to test\nif the kernel doesn't provide one itself. Note, we need to use a\ndifferent function signature for strlcpy() from what the kernel might\nhave otherwise the test build succeeds when the kernel does provide a\nstrlcpy().\n\nUpdate the OpenAFS kernel specific roken.h to define the prototype for\nstrlcpy when it's not present in the Linux kernel. We need to match the\ndefines used in the 'real' roken.h so the roken/strlcpy.c can build\nproperly. Add defines for ROKEN_LIB_FUNCTION, ROKEN_LIB_CALL and\nROKEN_LIB_VARIABLE to the kernel roken.h\n\nUpdate Linux's osi_machdep.h to include roken.h so the strlcpy protoype\nis available.\n\nUpdate the Linux MakefileProto to include the strcpy-kernel object\nwhen building the kernel module.\n\nReviewed-on: https://gerrit.openafs.org/15646\nTested-by: BuildBot \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 30b18c165752e6d0ce7b6daa6a90453f5e5e6d17)\n\nChange-Id: I8013623e8f735d15bb7d4ac84ed0867f12b77783\nReviewed-on: https://gerrit.openafs.org/15706\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"Linux 6.8: Use roken's strlcpy() in kernel module"}},{"before":"18a2a932df9c1b6b3c7513a6c161d4259f052ca9","after":"6333fae573f8a7b7656e9c1b05d445a37b951b88","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-16T16:20:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"Linux 6.8: Remove ctl_table sentinels\n\nThe Linux 6.8 commit 'sysctl: Remove the now superfluous sentinel\nelements from ctl_table array' (c8a65501d3) was a clean up commit\nthat removed the sentinel entry in the ctl_table array (e.g. the\n\"null\" entry at the end of the table).\n\nAs of Linux 6.8, including the sentinel entry (.procname =) in the\nctl_table is unnecessary, but doesn't yet break anything. But it is\nlikely that including the sentinel will start to cause runtime errors in\nfuture Linux versions very soon, so avoid the sentinel when we can, to\navoid possible problems in the future.\n\nDefine a new macro that can be used as the last entry of a ctl_table\nthat will either add a \"null\" entry, or nothing.\n\nThere is not a specific build test we can use within configure, so we\nmust explicitly test the Linux version to decide if we need to use a\nsentinel or not when defining the macro. We are selecting 6.8 to match\nthe version where the Linux kernel is removing the sentinels from the in\nkernel filesystems.\n\nNote: See the Linux merge commits 'Merge tag 'sysctl-6.8-rc1' of\ngit://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux' (a05aea98d4)\nfor more details behind the staged removal of the sentinels in the\nctl_table structures and the potential future change for removing the\nactual check for the sentinel within the Linux kernel.\n\nReviewed-on: https://gerrit.openafs.org/15645\nTested-by: BuildBot \nReviewed-by: Mark Vitale \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 35c8c1bf0b1cb48178f676ba5bcf16ad59c5a33b)\n\nChange-Id: I34cb7586003e10a6c7438d7205123d57af30585e\nReviewed-on: https://gerrit.openafs.org/15705\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"Linux 6.8: Remove ctl_table sentinels"}},{"before":"fef1fc6f740c6f7395cf51ce99ed296652579c7d","after":"18a2a932df9c1b6b3c7513a6c161d4259f052ca9","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-16T16:09:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"Linux 6.8: use hlist iteration for dentry children\n\nLinux 6.8 commit 'dentry: switch the lists of children to hlist'\n(da549bdd15) replaces the dentry lists d_subdirs/d_child with the hlist\nd_children/d_sib.\n\nAdd an autoconf test for a d_children member in the dentry structure.\n\nDefine a macro that uses the applicable Linux function for iterating\nover a dentry's children.\n\nReviewed-on: https://gerrit.openafs.org/15632\nReviewed-by: Andrew Deason \nTested-by: BuildBot \nReviewed-by: Mark Vitale \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 8e0bbe6a07523dd2e7efb3c9d1b4ad9e19fc9bb7)\n\nChange-Id: Ief4c334c4ef3e54822e068dcdf654541e86b9176\nReviewed-on: https://gerrit.openafs.org/15704\nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nTested-by: Andrew Deason \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"Linux 6.8: use hlist iteration for dentry children"}},{"before":"57e0192a690942c2a0f4f1f685cfadf2106b763a","after":"fef1fc6f740c6f7395cf51ce99ed296652579c7d","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-16T04:42:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"rxgen: Declare generated PKG_OpCodeStats()\n\nThe function {PKG}_OpCodeStats() is generated by rxgen, however a\nprototype for the function is not generated.\n\nThe functions h_ProcMainBody_setup() and h_HeadofOldStyleProc_setup()\nin rpc_parse.c emit prototypes for {PKG}_ExecuteRequest() and\n{PKG}_TranslateOpCode(), but do not emit a prototype for\n{PKG}_OpCodeStats().\n\nUpdate rxgen to emit a function prototype for {PKG}_OpCodeStats() in the\ngenerated header file.\n\nUse a variable to point to \"PackagePrefix[PackageIndex]\" in\nh_ProcMainBody_setup to improve readability.\n\n{PKG}_OpCodeStats(), specifically RXSTATS_OpCodeStats(), is flagged due\nto a missing prototype when building against a Linux 6.8 kernel (which\nsets the -Wmissing-declarations and -Wmissing-prototypes compiler flags\nas default). Linux 6.8 commit: 'Makefile.extrawarn: turn on\nmissing-prototypes globally' (0fcb70851f). When building against a\nkernel with CONFIG_WERROR=y, the build fails.\n\nReviewed-on: https://gerrit.openafs.org/15631\nTested-by: BuildBot \nReviewed-by: Mark Vitale \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 26bb4d143b31ba027cf2721ac731df67a174c43b)\n\nChange-Id: I9072d22d142b5b7a2f59b0cfc4026066ef1d9501\nReviewed-on: https://gerrit.openafs.org/15703\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"rxgen: Declare generated PKG_OpCodeStats()"}},{"before":"4c92936aefede187e57a9a433c0c192af2fc5e84","after":"57e0192a690942c2a0f4f1f685cfadf2106b763a","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-13T03:10:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"rxgen: Declare generated PKG_TranslateOpCode()\n\nEver since commit 5c77a6ca (rxgen: add *TranslateOpcode functions to\nXDR code), rxgen generates a PKG_TranslateOpCode function in the\nrelevant .xdr.c source, which can translate an RPC opcode into the RPC\nname. But we never declare this function in a header file, making it\nimpossible to use without compiler warnings (unless the caller\ndeclares the function itself).\n\nTo make it possible to actually use this function, declare this\nfunction in the generated header file.\n\nReviewed-on: https://gerrit.openafs.org/14871\nReviewed-by: Cheyenne Wills \nTested-by: BuildBot \nReviewed-by: Mark Vitale \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 9b2c27fc6d299cb0b23eca3e8cb25b7e0c41b11a)\n\nChange-Id: I2479ff7f6579769b3319b2939ffde60fe570c880\nReviewed-on: https://gerrit.openafs.org/15702\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"rxgen: Declare generated PKG_TranslateOpCode()"}},{"before":"195f154aaf2d8aff1f6debdb47c0db8f07cb5c5e","after":"4c92936aefede187e57a9a433c0c192af2fc5e84","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-13T03:06:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"rx: Add static attribute to internal functions\n\nWhen building against a Linux 6.8 kernel, functions that are missing\nprototypes or declarations are flagged.\n\nWe can add the static attribute to functions that are not referenced\noutside of the file that implements them to avoid having these functions\nflagged by the compiler.\n\nThese functions are flagged due to missing prototypes when building\nagainst a Linux 6.8 kernel (which sets the -Wmissing-declarations and\n-Wmissing-prototypes compiler flags as default). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nWhen building against a kernel with CONFIG_WERROR=y, the build fails.\n\nThere are no functional changes in this commit.\n\nReviewed-on: https://gerrit.openafs.org/15626\nReviewed-by: Andrew Deason \nTested-by: BuildBot \nReviewed-by: Mark Vitale \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 55adceba2d561ec4e89235de329782a68e603a11)\n\nChange-Id: I1b2a6e1c07bd4b75b7b83e177f17865eb903e488\nReviewed-on: https://gerrit.openafs.org/15701\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"rx: Add static attribute to internal functions"}},{"before":"90b8dcff36e9b03ec01550ad1a070a0ab7db8c46","after":"195f154aaf2d8aff1f6debdb47c0db8f07cb5c5e","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-13T03:03:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"afs: Add static attribute to internal functions\n\nWhen building against a Linux 6.8 kernel, functions that are missing\nprototypes or declarations are flagged.\n\nWe can add the static attribute to functions that are not referenced\noutside of the file that implements them to avoid having these functions\nflagged by the compiler.\n\nThese functions are flagged due to missing prototypes when building\nagainst a Linux 6.8 kernel (which sets the -Wmissing-declarations and\n-Wmissing-prototypes compiler flags as default). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nWhen building against a kernel with CONFIG_WERROR=y, the build fails.\n\nThere are no functional changes in this commit.\n\nReviewed-on: https://gerrit.openafs.org/15625\nTested-by: BuildBot \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit efee796f28b53bf3ffc03186f81790c36c23c94c)\n\nChange-Id: I0d923a65731f825d6c190056b0ccc3d362236706\nReviewed-on: https://gerrit.openafs.org/15700\nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nTested-by: Benjamin Kaduk \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"afs: Add static attribute to internal functions"}},{"before":"09f9660fbbb4f3c20ba9f2283169818372c3f474","after":"90b8dcff36e9b03ec01550ad1a070a0ab7db8c46","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-13T02:52:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"afs: fix 'ops' variable may be used uninitialized\n\nWhen the function rxfs_storeInit() has the static attribute, gcc flags\nthe variable 'ops' as possibly uninitialized.\n\nIn function 'afs_CacheStoreDCaches',\n inlined from 'afs_CacheStoreVCache' at\n .../src/afs/afs_fetchstore.c:630:14:\n .../afs/afs_fetchstore.c:535:17: error: 'ops' may be used\n uninitialized [-Werror=maybe-uninitialized]\n 535 | code = (*ops->destroy)(&rock, code);\n | ~^~~~~~~~~~~~~~\n ...src/afs/afs_fetchstore.c: In function 'afs_CacheStoreVCache':\n ...src/afs/afs_fetchstore.c:567:22: note: 'ops' was declared here\n 567 | struct storeOps *ops;\n | ^~~\n cc1: all warnings being treated as errors\n\nThis is a false positive report by the gcc compiler.\n\nThe function rxfs_storeInit() returns a 0 only when it has successfully\nassigned a value to the ops variable, and afs_CacheStoreDcaches() is\nonly called if the return value from rxfs_storeInit() is 0.\n\nThe ops variable is only used within a block that is within a for loop,\nwhich could leave a stray value if the variable isn't initialized within\nthat loop.\n\nAssigning a NULL to ops is sufficient to avoid the compiler error, and\nrelocating the declaration of the ops variable into the block where it\nis actually used ensures that it's always initialized before its use\nwithin the loop.\n\nClean up whitespace in the statement that follows the new location for\nthe ops variable.\n\nNote, this commit is being added before a commit that adds the static\nattribute to the rxfs_storeInit() function which also \"fixes\" the\ncompiler error (see: afs: Add static attribute to internal functions).\n\nReviewed-on: https://gerrit.openafs.org/15630\nReviewed-by: Andrew Deason \nTested-by: BuildBot \nReviewed-by: Mark Vitale \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 36e4c02ff27b9d66755b9544778896b9b1e5c391)\n\nChange-Id: I9d8a07e576c6bf889f8f182c6fc0d34dc997c004\nReviewed-on: https://gerrit.openafs.org/15699\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"afs: fix 'ops' variable may be used uninitialized"}},{"before":"53752b01bc734f4bd5f5da24ac116c7fcb2ac07f","after":"09f9660fbbb4f3c20ba9f2283169818372c3f474","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-13T02:48:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"rx: Add function prototypes to rx_prototypes.h\n\nThe prototype for rxk_NewSocketHost() is not in a header file, but is\ndefined in the referencing .c file. The ARCH/rx_knet.c files that\nimplement rxk_NewSocketHost() do not have a prototype (but when the\nrx_kcommon.c implementation is used it does have a prototype, since\nrx_kcommon.c is the \"referencing .c file\").\n\nAdd the prototype for rxk_NewSocketHost() to rx_prototypes.h and\nremove the prototype from rx_kcommon.c\n\nThe prototypes for the functions rx_DebugOnOff() and rx_StatsOnOff()\nare defined within rx_prototypes.h, but are within a preprocessor\nconditional for AFS_NT40_ENV, however the implementation for these\n2 functions do not have the preprocessor conditional.\n\nRearrange the prototypes for rx_DebugOnOff() and rx_StatsOnOff() so they\nare outside the AFS_NT40_ENV preprocessor conditional.\n\nThese functions are flagged due to missing prototypes when building\nagainst a Linux 6.8 kernel (which sets the -Wmissing-declarations and\n-Wmissing-prototypes compiler flags as default). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nWhen building against a kernel with CONFIG_WERROR=y, the build fails.\n\nThere are no functional changes in this commit.\n\nReviewed-on: https://gerrit.openafs.org/15624\nReviewed-by: Mark Vitale \nReviewed-by: Cheyenne Wills \nTested-by: Benjamin Kaduk \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 8528c36b96fe2935f42188caabf4feed0d5dbcbd)\n\nChange-Id: Ieae8be7f89f5c675c6580d8cfb02ea77ce4088f7\nReviewed-on: https://gerrit.openafs.org/15698\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"rx: Add function prototypes to rx_prototypes.h"}},{"before":"96932160fa8ef1cf4422e9e1d1ca2a449f8ffe93","after":"53752b01bc734f4bd5f5da24ac116c7fcb2ac07f","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-13T02:46:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"afs: Remove SRXAFSCB* protos from afs_prototypes.h\n\nThe prototypes for the afscbint RPC functions (SRXAFSCB_*) implemented\nin afs_callback.c are defined in 2 locations, afs_protypes.h and\nafscbint.h (which is generated by rxgen).\n\nRemove the protoypes for the SRXAFSCB_* functions from afs_prototypes.h\nas they are redundant and are currently out of sync (the prototypes\nfor SRXAFSCB_GetCellByNum() and SRXAFSCB_TellMeAboutYourself() are\nnot present in afs_prototypes.h). Also remove a redundant prototype for\nafs_RXCallBackServer() which was prototyped both before and in the\nmiddle of the SRXAFSCB* prototypes.\n\nSince afs_callback.c only pulled in afs_prototypes.h and not afscbint.h,\nadd an include for afscbint.h to ensure that the all the prototypes for\nthe SRXAFSCB_* functions are present.\n\nThe 2 functions listed above are flagged due to missing prototypes when\nbuilding against a Linux 6.8 kernel (which sets the\n-Wmissing-declarations and -Wmissing-prototypes compiler flags as\ndefault). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nWhen building against a kernel with CONFIG_WERROR=y, the build fails.\n\nReviewed-on: https://gerrit.openafs.org/15644\nReviewed-by: Mark Vitale \nTested-by: Benjamin Kaduk \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit fae4003b403420d0b548920c7837a2d2b6e432ae)\n\nChange-Id: I7d435455fc60cc10200ee91d0d76534367ab5883\nReviewed-on: https://gerrit.openafs.org/15697\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"afs: Remove SRXAFSCB* protos from afs_prototypes.h"}},{"before":"c04c2d07226583846c3949a4855c7db4316438da","after":"96932160fa8ef1cf4422e9e1d1ca2a449f8ffe93","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-12T22:07:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"afs: Add afs_xioctl prototyes to afs_prototypes.h\n\nSeveral .c files have external function prototypes for the afs_xioctl\nfunction, while the implementing files do not have the prototype.\n\nMove these prototypes into afs_prototypes.h so that the prototypes are\navailable to both the caller and the implementation.\n\nBecause the file holding the implementation does not have a prototypes,\nafs_xioctl() is being flagged when building against a Linux 6.8 kernel\n(which sets the -Wmissing-declarations and -Wmissing-prototypes compiler\nflags as default). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nWhen building against a Linux kernel with CONFIG_WERROR=y, the build\nfails.\n\nNote that the function afs_xioctl() has platform specific\nimplementations.\n\nReviewed-on: https://gerrit.openafs.org/15643\nReviewed-by: Andrew Deason \nTested-by: BuildBot \nReviewed-by: Mark Vitale \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 575d986aa6c18ac27ea42fb66ae8b8cb0e27fe6c)\n\nChange-Id: If746111fdcf6a00459f524711623d322d5fc7942\nReviewed-on: https://gerrit.openafs.org/15696\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"afs: Add afs_xioctl prototyes to afs_prototypes.h"}},{"before":"8b516820abf1edace60276152e9ed18a0b30fc13","after":"c04c2d07226583846c3949a4855c7db4316438da","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-12T22:04:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"afs: Move function prototypes into headers\n\nSeveral .c files contain external function prototypes, while the\nimplementing files do not have these prototypes.\n\nMove these prototypes into header files so that the prototypes are\navailable to both the caller and the implementation.\n\nBecause the file holding the implementation does not have prototypes,\nthese functions are flagged when building against a Linux 6.8 kernel\n(which sets the -Wmissing-declarations and -Wmissing-prototypes compiler\nflags as default). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nWhen building against a kernel with CONFIG_WERROR=y, the build fails.\n\nAdd the prototypes for the following to afs_prototypes.h:\n exporter_add\n afs_syscall (AFS_LINUX_ENV)\n BlobScan\n\nRemove the prototypes from the .c files where they are referenced.\n\nReviewed-on: https://gerrit.openafs.org/15642\nReviewed-by: Andrew Deason \nTested-by: BuildBot \nReviewed-by: Mark Vitale \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 85781d7e83ae4501d8ab267bf55ef63f90f63101)\n\nChange-Id: I74333e99e08af88bebdcbff4767d79397acac358\nReviewed-on: https://gerrit.openafs.org/15695\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"afs: Move function prototypes into headers"}},{"before":"25e17fe7196fd4a46e6a9408d135812ca53ddf80","after":"8b516820abf1edace60276152e9ed18a0b30fc13","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-12T21:53:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"afs: Add includes to pick up function prototypes\n\nThe functions defined in LINUX/osi_crypto.c, osi_pagecopy.c,\nosi_probe.c, and osi_syscall.c have function prototypes defined in\nexisting header files, however either due to missing includes or\npreprocessor conditionals that skip the includes, these function\nprototypes are not being pulled in.\n\nThese functions are flagged due to missing prototypes when building\nagainst a Linux 6.8 kernel (which sets the -Wmissing-declarations and\n-Wmissing-prototypes compiler flags as default). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nWhen building against a kernel with CONFIG_WERROR=y, the build fails.\n\nAdd the necessary includes to osi_crypto.c and osi_pagecopy.c and\nre-arrange the includes in osi_probe.c and osi_syscall.c to ensure that\nthe function prototypes are present when building the Linux kernel\nmodule.\n\nReviewed-on: https://gerrit.openafs.org/15641\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 3683f15278e34e13d7272928eaf666f0acc4e1e9)\n\nChange-Id: Iac704fc98d0d685358224049f383d68aa7a105f8\nReviewed-on: https://gerrit.openafs.org/15694\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"afs: Add includes to pick up function prototypes"}},{"before":"b1c93f13870e24795b857cb483320871703d00e8","after":"25e17fe7196fd4a46e6a9408d135812ca53ddf80","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-12T21:48:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"afs: Declare init_hckernel_mutex()\n\nThe function init_hckernel_mutex() (in rand.c) is flagged due to a\nmissing prototype when building against a Linux 6.8 kernel (which sets\nthe -Wmissing-declarations and -Wmissing-prototypes compiler flags as\ndefault). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nWhen building against a kernel with CONFIG_WERROR=y, the build fails.\n\nAdd a function prototype for init_hckernel_mutex() to afs_osi.h and\nremove the prototype from afs_osi.c\n\nThere are no functional changes with this commit.\n\nReviewed-on: https://gerrit.openafs.org/15622\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit ccc2af429710104793fb4659b10697cceab182b3)\n\nChange-Id: Ic5eb4584a980657a01a1cb4411c0c1f03b1f3560\nReviewed-on: https://gerrit.openafs.org/15693\nReviewed-by: Andrew Deason \nTested-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"afs: Declare init_hckernel_mutex()"}},{"before":"15357006d9e8e45ac0be9e0c7e87456ee3857d90","after":"b1c93f13870e24795b857cb483320871703d00e8","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-12T21:46:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"Linux 6.8: Add function prototypes for krb5\n\nThe external files for heimdal/krb5 do not provide function prototypes\nin a header file that is used when building files that we use from\nheimdal/krb5 (e.g. crypto.c).\n\nThese functions are flagged due to missing prototypes when building\nagainst a Linux 6.8 kernel (which sets the -Wmissing-declarations and\n-Wmissing-prototypes compiler flags as default). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nWhen building against a kernel with CONFIG_WERROR=y, the build fails.\n\nWe cannot modify the external source files, however there is the local\nOpenAFS include file, krb5_locl.h, that does contain OpenAFS specific\nchanges.\n\nAdd declarations to krb5_locl.h for the functions defined in the\nheimdal/krb5 source.\n\nThere are no functional changes with this commit.\n\nReviewed-on: https://gerrit.openafs.org/15621\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 612927dd1dd44bbd08eda790de12b24213583156)\n\nChange-Id: Iaae28186a24c3c5ca4407de9563c8cfed9644921\nReviewed-on: https://gerrit.openafs.org/15692\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"Linux 6.8: Add function prototypes for krb5"}},{"before":"799d789fbaefc8c4dbcb803b885deb35f4947d26","after":"2d980aaef7a7e0c874ca21a988ba5cf710151302","ref":"refs/heads/master","pushedAt":"2024-05-10T18:41:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"rxgk: Initialize 'iterations'\n\ngcc 4.4.7 (used on RHEL6) throws a warning that 'iterations' is used\nuninitialized:\n\n .../src/rxgk/rxgk_crypto_rfc3961.c: In function 'PRFplus':\n .../src/rxgk/rxgk_crypto_rfc3961.c:621: error: 'iterations' may be used uninitialized in this function [-Wuninitialized]\n\nIt's not actually possible for 'iterations' to be used uninitialized;\nwe only use it in the 'done' destructor if 'pre_key' is set. But\ninitialize 'iterations' to 0 to avoid the warning.\n\nChange-Id: I7ec3d033847a8804899f4d9fe163a56586812d4d\nReviewed-on: https://gerrit.openafs.org/15750\nReviewed-by: Benjamin Kaduk \nTested-by: BuildBot \nReviewed-by: Cheyenne Wills ","shortMessageHtmlLink":"rxgk: Initialize 'iterations'"}},{"before":"5d2c4a0a8ada4a87d7f39dc21dbce14b3b2a978f","after":"15357006d9e8e45ac0be9e0c7e87456ee3857d90","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-09T16:23:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"roken: Declare ct_memcmp in hcrypto kernel roken.h\n\nCurrently, we build roken's ct.c for our kernel module to provide\nct_memcmp(). We declare a prototype for ct_memcmp() in krb5_locl.h,\nand all of our kernel callers of ct_memcmp() include krb5_locl.h, so\nall callers get a prototype and avoid \"implicit declaration\" compiler\nwarnings.\n\nHowever, roken's ct.c itself does not include krb5_locl.h, so it\ndoesn't get a prototype for ct_memcmp(). This is dangerous, since if\nthe prototype ever slightly differs from the implementation for any\nreason, it could cause a variety of issues.\n\nThis also causes warnings when building against a Linux 6.8 kernel\n(which sets the -Wmissing-declarations and -Wmissing-prototypes\ncompiler flags as default). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nWhen building against a kernel with CONFIG_WERROR=y, the build fails.\n\nWe cannot change ct.c, since it is an external source file. To fix\nthis, instead move the prototype of ct_memcmp() to our stub\nkernel-only roken.h header, which is included by ct.c. Make\nkrb5_locl.h also include roken.h when building kernel code, so all of\nthe ct_memcmp() callers also get the prototype.\n\nWhile we're here, add some informative comments and an include guard\nto our previously-blank roken.h stub.\n\nWritten in collaboration with cwills@sinenomine.net.\n\nReviewed-on: https://gerrit.openafs.org/15620\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit be236069e9d26339ed5f9939965bca0dd3f8bf4e)\n\nChange-Id: I1112881938b0585263871f8f83d63b8909b12f0d\nReviewed-on: https://gerrit.openafs.org/15691\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"roken: Declare ct_memcmp in hcrypto kernel roken.h"}},{"before":"73844a4939a7b8198bf11d4dcbce9e28b621bd11","after":"5d2c4a0a8ada4a87d7f39dc21dbce14b3b2a978f","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-02T16:24:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"afs: Add declaration for RXAFS_ResidencyCmd()\n\nThe function RXAFS_ResidencyCmd() is 'manually' defined within the\nafsint.xg, so a prototype for the function is not defined.\n\nThis function is flagged due to a missing prototype when building\nagainst a Linux 6.8 kernel (which sets the -Wmissing-declarations and\n-Wmissing-prototypes compiler flags as default). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nWhen building against a kernel with CONFIG_WERROR=y, the build fails.\n\nAdd a prototype for RXAFS_ResidencyCmd\n\nThere are no functional changes with this commit\n\nThe function RXAFS_ResidencyCmd() was introduced with commit:\n'rename-residency-from-mrafs-to-osd-20090427' (8655541d1e)\n\nReviewed-on: https://gerrit.openafs.org/15619\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 1d6cfbc5f627abf3808aae97afb72662301483b5)\n\nChange-Id: I42d0868b83e119b0c3348a3af8aaf5961c040bb2\nReviewed-on: https://gerrit.openafs.org/15690\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"afs: Add declaration for RXAFS_ResidencyCmd()"}},{"before":"be8001f1d64a2d9da4fdaeff59fdc40e205d4526","after":"73844a4939a7b8198bf11d4dcbce9e28b621bd11","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-02T16:18:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"afs: Remove afs_DbgDisconFiles()\n\nThe function afs_DbgDisconFiles() is not referenced anywhere within the\nsource tree.\n\nRemove the function afs_DbgDisconFiles().\n\nThe commit: 'disconnected-rw-20080922' (433afd4779) introduced\nafs_DbgDisconFiles(), but the function was never used.\n\nThis function is flagged due to a missing prototype when building\nagainst a Linux 6.8 kernel (which sets the -Wmissing-declarations and\n-Wmissing-prototypes compiler flags as default). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nWhen building against a kernel with CONFIG_WERROR=y, the build fails.\n\nReviewed-on: https://gerrit.openafs.org/15640\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 32bb90047782f41df521bba5ab4aba8b4ed34203)\n\nChange-Id: I61d06515845dbb18a370f7856285596514242e99\nReviewed-on: https://gerrit.openafs.org/15689\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"afs: Remove afs_DbgDisconFiles()"}},{"before":"bb7eaafb2e87d313eeb0a7bedebe2aa7a797b005","after":"be8001f1d64a2d9da4fdaeff59fdc40e205d4526","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-02T16:15:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"afs: Remove SRXAFSCB_FetchData/StoreData\n\nCommit 'client-64bit-file-size-support-20011031' (971b18bc42) introduced\nthe RPC functions SRXAFSCB_FetchData() and SRXAFSCB_StoreData with RPC\nnumbers of 65536 and 65537 respectively.\n\nCommit 'more-64bit-file-size-support-20011031' (c5b1a3775f) removed the\nreferences from afscbint.xg, but did not remove the actual code. The\n65536 RPC number was reassigned to SRXAFSCB_GetCE64, and the commit:\n'This is mostly a rewrite of src/afs/afs_cell.c, and associated changes'\n(629d08065) assigned the 65537 RPC to SRXAFSCB_GetCellByNum.\n\nRemove the 2 functions since there are no references other than the\nprototype in afs_prototypes.h.\n\nThis function is flagged due to a missing prototype when building\nagainst a Linux 6.8 kernel (which sets the -Wmissing-declarations and\n-Wmissing-prototypes compiler flags as default). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nReviewed-on: https://gerrit.openafs.org/15639\nReviewed-by: Andrew Deason \nTested-by: BuildBot \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 379f7fc51d411990189ec28e48c91edc87d76120)\n\nChange-Id: I1a3539227d22e6df89d78245634dfeb14943035a\nReviewed-on: https://gerrit.openafs.org/15688\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"afs: Remove SRXAFSCB_FetchData/StoreData"}},{"before":"bd2828f1ab4c88b95a5d075e29a942922aa86dba","after":"bb7eaafb2e87d313eeb0a7bedebe2aa7a797b005","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-05-02T16:10:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"afs: Remove DFlushDCache()\n\nThe function DFlushDcache() is not referenced anywhere within the\nsource tree.\n\nRemove the function DFlushDCache().\n\nThe commit: 'disconnected-shadow-directory-fixes-20090121' (4045f3d535)\nremoved the code reference to DFlushDCache() and the commit:\n\"dir: Prototype and function name cleanup\" (5ad1e6cb90) removed the\nfunction prototype. The function was introduced in the commit:\n\"disconnected-flush-before-shadowing-20090119\" (e1cc987ea5).\n\nThis function is flagged due to a missing prototype when building\nagainst a Linux 6.8 kernel (which sets the -Wmissing-declarations and\n-Wmissing-prototypes compiler flags as default). Linux 6.8 commit:\n \"Makefile.extrawarn: turn on missing-prototypes globally\" (0fcb70851f).\n\nWhen building against a kernel with CONFIG_WERROR=y, the build fails.\n\nReviewed-on: https://gerrit.openafs.org/15615\nTested-by: Benjamin Kaduk \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 432ac5810e51bb5bb2cf1df0bfebc64d1c4d7a39)\n\nChange-Id: Ib8ab79c76c633632215e02235f47fdb1d744e721\nReviewed-on: https://gerrit.openafs.org/15684\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"afs: Remove DFlushDCache()"}},{"before":"cc8053e86eef75bff308e7606f2618e9fdc4ec5d","after":"bd2828f1ab4c88b95a5d075e29a942922aa86dba","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-04-27T03:16:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"afs: Remove dummy_PSetAcl()\n\nThe function dummy_PSetAcl() is not referenced anywhere within the\nsource tree.\n\nRemove the function dummy_PSetAcl().\n\nThe commit: 'doxygen-comments-20081010' (4b72f8765c)\nintroduced the function, but dummy_PSetAcl() has never been referenced\nor defined within a header file.\n\nThis function is flagged due to a missing prototype when building\nagainst a Linux 6.8 kernel (which sets the -Wmissing-declarations and\n-Wmissing-prototypes compiler flags as default). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nWhen building against a kernel with CONFIG_WERROR=y, the build fails.\n\nReviewed-on: https://gerrit.openafs.org/15618\nReviewed-by: Benjamin Kaduk \nTested-by: Benjamin Kaduk \n(cherry picked from commit 05ca98687d882c72915e91430e29a4f2a36c502c)\n\nChange-Id: Ie4420a365e07d2d8564530e004df75330e86bea5\nReviewed-on: https://gerrit.openafs.org/15687\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"afs: Remove dummy_PSetAcl()"}},{"before":"407c6371572b1b7e815f30c0718e14b1c6b385e5","after":"799d789fbaefc8c4dbcb803b885deb35f4947d26","ref":"refs/heads/master","pushedAt":"2024-04-26T22:48:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"afs: Reintroduce and use DFlushDCache()\n\nThis reverts commit 432ac5810e51bb5bb2cf1df0bfebc64d1c4d7a39 (afs:\nRemove DFlushDCache()). This also re-adds the caller of DFlushDCache()\nremoved by commit 4045f3d5350955de91e019b09ad2ed7941f6dadb\n(disconnected-shadow-directory-fixes-20090121), and the prototype\nremoved by commit 5ad1e6cb904b953fbb04603f3ce1466dcc38cd48 (dir:\nPrototype and function name cleanup).\n\nThe removal of the DFlushDCache() call in commit 4045f3d535 seems like\na mistake. If the directory in question has dirty pages in memory, we\nneed to flush those to the cache before making a copy of the\ndirectory's data, because we read the existing dir's data from the\ncache. If we don't flush, afs_MakeShadowDir() might make a copy of the\ndcache that is missing updates to the directory blob.\n\nChange-Id: I4f26103b3db5e1ebdbe3324d2d9f67b39ab22e09\nReviewed-on: https://gerrit.openafs.org/15740\nTested-by: BuildBot \nReviewed-by: Benjamin Kaduk \nReviewed-by: Cheyenne Wills ","shortMessageHtmlLink":"afs: Reintroduce and use DFlushDCache()"}},{"before":"4881af8e3cf3f7d09670ba4b5bb9b644a329530d","after":"cc8053e86eef75bff308e7606f2618e9fdc4ec5d","ref":"refs/heads/openafs-stable-1_8_x","pushedAt":"2024-04-25T17:47:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"openafs","name":null,"path":"/openafs","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/150141?s=80&v=4"},"commit":{"message":"afs: Remove afs_osi_UnmaskUserLoop()\n\nThe function afs_osi_UnmaskUserLoop() is not referenced anywhere within\nthe source tree.\n\nRemove the function afs_osi_UnmaskUserLoop().\n\nThe commit: 'darwin-afsdb-handler-signal-mask-20040728' (9728182c00)\nintroduced the function, but afs_osi_UnmaskUserLoop() has never been\nreferenced or defined within a header file.\n\nThis function is flagged due to a missing prototype when building\nagainst a Linux 6.8 kernel (which sets the -Wmissing-declarations and\n-Wmissing-prototypes compiler flags as default). Linux 6.8 commit:\n 'Makefile.extrawarn: turn on missing-prototypes globally' (0fcb70851f).\n\nWhen building against a kernel with CONFIG_WERROR=y, the build fails.\n\nReviewed-on: https://gerrit.openafs.org/15617\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Benjamin Kaduk \n(cherry picked from commit 587cfce29cb4e014e5b8d96e0433c5e7d2c6729a)\n\nChange-Id: I0fe91a41e8f00773cb1d5976a8c3e39e4415f6bc\nReviewed-on: https://gerrit.openafs.org/15686\nTested-by: BuildBot \nReviewed-by: Andrew Deason \nReviewed-by: Michael Meffie \nReviewed-by: Benjamin Kaduk ","shortMessageHtmlLink":"afs: Remove afs_osi_UnmaskUserLoop()"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUnrKBgA","startCursor":null,"endCursor":null}},"title":"Activity ยท openafs/openafs"}