New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headers to lowercase #306

Merged

gehrisandro merged 1 commit into openai-php:main from chengxs1994:headers-lowercase

Dec 22, 2023

chengxs1994 commented Dec 22, 2023 •

edited

Loading

What:

Bug Fix
New Feature

Description:

Related:


          headers to lowercase

312dfb6

chengxs1994 mentioned this pull request

[Bug]: transcribe 3 times and did not succeed #301

Closed

huangdijia approved these changes

View reviewed changes

Collaborator

gehrisandro commented Dec 22, 2023

Hi @chengxs1994

Thank you for your PR!

Could you provide an example why this changes is necessary? As far as I understand the OpenAI docs, the headers should always be in lowercase.

gehrisandro self-assigned this

huangdijia commented Dec 22, 2023 •

edited

Loading

According to the psr specification, the getHeaderLine method is case insensitive, but the conversion to array does not automatically convert to lowercase

https://www.php-fig.org/psr/psr-7/

While header names are not case-sensitive, getHeaders() will preserve the exact case in which headers were originally specified.

Collaborator

gehrisandro commented Dec 22, 2023

Thanks for clarification 👍

gehrisandro merged commit ec1dde4 into openai-php:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet