Skip to content

Fixes off-by-one error in PrioritizedReplayBuffer#174

Closed
ghost wants to merge 4 commits into
masterfrom
unknown repository
Closed

Fixes off-by-one error in PrioritizedReplayBuffer#174
ghost wants to merge 4 commits into
masterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Oct 20, 2017

Fixes #170
Fixes #171

@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 20, 2017

Also makes documentation of segment_tree consistent with tests.

The tests clearly indicate that the end parameter is non-inclusive: https://github.com/openai/baselines/blob/master/baselines/common/tests/test_segment_tree.py#L17

@siemanko, please review.

@ghost ghost closed this by deleting the head repository Mar 13, 2025
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants