Add new enterprise requirement gate#23736
Conversation
adams-oai
force-pushed
the
codex/add-enterprise-requirement-gate
branch
from
550ad43 to
6579f24
Compare
adams-oai
force-pushed
the
codex/add-enterprise-requirement-gate
branch
from
6579f24 to
9158ca0
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5ecbee8cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| permission_profile: mut constrained_permission_profile, | ||
| web_search_mode: mut constrained_web_search_mode, | ||
| allow_managed_hooks_only: _, | ||
| allow_appshots: _, |
There was a problem hiding this comment.
When cloud or system requirements set allow_appshots = false, the new requirement is parsed and exposed through debug/API output, but it is discarded while building the effective Config; a repo-wide search shows no other allow_appshots/appshots consumer in this tree, so those sessions still behave as if appshots are allowed. If this is intended to be an enterprise gate, wire the value into the feature/config path that enables appshots rather than only reporting it.
Useful? React with 👍 / 👎.
3 participants
Add new enterprise requirement gate.
Validation:
cargo test -p codex-config --libcargo test -p codex-app-server-protocol --libcargo test -p codex-tui --lib debug_configcargo test -p codex-app-server --lib(fails: stack overflow inin_process::tests::in_process_start_initializes_and_handles_typed_v2_request; reproduces when run alone)