Add trace_id to TurnStartedEvent#23980
Merged
Merged
Conversation
mchen-oai
force-pushed
the
mchen/TurnContextItem-trace_id
branch
from
c0d9578 to
07d7be3
Compare
mchen-oai
changed the title
Collaborator
|
@pakrym-oai removed, will let him stamp |
mchen-oai
force-pushed
the
mchen/TurnContextItem-trace_id
branch
from
07d7be3 to
688609f
Compare
mchen-oai
force-pushed
the
mchen/TurnContextItem-trace_id
branch
from
688609f to
9968b1f
Compare
mchen-oai
changed the title
mchen-oai
force-pushed
the
mchen/TurnContextItem-trace_id
branch
from
b10873d to
2399586
Compare
pakrym-oai
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Recent PR removed
trace_idfromTurnContextItem.What changed
TurnStartedEventso rollout consumers can correlate turns with telemetry traces.TurnContextItem, but we decided to move it toTurnStartedEvent.Verification
cargo test -p codex-protocolcargo test -p codex-core --lib regular_turn_emits_turn_started_without_waiting_for_startup_prewarmcargo test -p codex-core --test all emits_warning_when_resumed_model_differscargo test -p codex-rolloutcargo test -p codex-state