Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26604e528e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Run the following in PowerShell on Windows to install Codex CLI: | ||
|
|
||
| ``` | ||
| irm https://chatgpt.com/codex/install.ps1 | pwsh -NoProfile -ExecutionPolicy Bypass -Command - |
There was a problem hiding this comment.
Avoid requiring pwsh in Windows install command
This line says to run the command in PowerShell but then pipes the script to pwsh, which is only available when PowerShell 7 is installed; on many Windows setups that only have Windows PowerShell (powershell.exe), the command fails with pwsh not found and the installer cannot run. Because this README section is the primary quickstart path, the instruction should execute in the current shell (for example via iex) or explicitly call powershell instead of requiring a separate executable.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Can you give me a concrete alternative? The PR body describes the error I ran into with iex.
Now that users can install via
curl(orirm), we should tell them about it so they no longer need to usenpm!Note that on one Windows machine I tested on, when I ran:
I got this error:
so we'll recommend the following that works from both
cmd.exeand PowerShell:This PR makes a slight update to
codex-rs/tui/src/update_action.rsto match.