Display workspace usage limit error copy from response header#24114
Merged
Conversation
fcoury-oai
approved these changes
May 22, 2026
Contributor
fcoury-oai
left a comment
There was a problem hiding this comment.
Reviewed only the code, didn't run any smoke tests.
The code looks good, but added 2 nitpicks and one request for additional test coverage, but not blockers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
openai/openai#947613addsX-Codex-Rate-Limit-Reached-Typefor Codex workspace credit-depletion and spend-cap responses. The CLI currently reads the adjacent promo header but otherwise renders generic usage-limit copy, so those responses do not explain the workspace-specific action the user needs to take.Backend dependency: https://github.com/openai/openai/pull/947613
What Changed
X-Codex-Rate-Limit-Reached-Typein the usage-limit error handling path alongsidex-codex-promo-message.RateLimitReachedTypeenum.UsageLimitReachedErrorand render client-owned copy for the four workspace owner/member credit and spend-cap values.Test Plan
usage_limit_reached_error_formats_rate_limit_reached_typescoverage.