[codex] Use rolling files for Windows sandbox logs#24117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Windows sandbox diagnostics currently append to a single
sandbox.logunderCODEX_HOME/.sandbox. That file never rolls over, which makes it hard to safely include sandbox diagnostics in future feedback reports without risking unbounded growth.What changed
tracing_appender::rolling::RollingFileAppender.sandbox.YYYY-MM-DD.log.MAX_LOG_FILEScap of 90 retained matching log files.This intentionally does not include sandbox logs in
/feedbackyet; scrubbing and attachment behavior can happen in a follow-up.Testing
cargo fmt -p codex-windows-sandboxcargo check -p codex-windows-sandboxcargo test -p codex-windows-sandboxcargo test -p codex-windows-sandbox logging::testscargo clippy -p codex-windows-sandbox --all-targets -- -D warnings