[codex-analytics] split compaction v2 analytics implementation#24146
Merged
Conversation
rhan-oai
force-pushed
the
rhan/compaction-v2-analytics
branch
from
d00c0fd to
73d4160
Compare
rhan-oai
changed the title
won-openai
approved these changes
May 22, 2026
Collaborator
won-openai
left a comment
won-openai
left a comment
There was a problem hiding this comment.
lgtm, simple pr next time pls
Collaborator
Author
|
for sure, will condense to 1 line next time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
responses_compaction_v2value forCodexCompactionEvent.implementation.responsesand legacy/responses/compactasresponses_compact.Why
Remote compaction v2 and local prompt-based compaction were both reported as
responses, which made the analytics table collapse two different compaction mechanisms into one implementation bucket.Validation
just fmtjust test -p codex-analyticsjust test -p codex-corewas started locally, but this PR is intentionally being pushed for CI to finish the remaining validation.