Skip to content

chore: add JSON schema policy fixture coverage#24152

Merged
celia-oai merged 4 commits into
mainfrom
dev/cc/integration-test
May 22, 2026
Merged

chore: add JSON schema policy fixture coverage#24152
celia-oai merged 4 commits into
mainfrom
dev/cc/integration-test

Conversation

@celia-oai
Copy link
Copy Markdown
Collaborator

@celia-oai celia-oai commented May 22, 2026

Why

Before changing the Codex Bridge JSON schema policy, add integration coverage around real connector-like MCP tool schemas. The existing unit tests cover individual sanitizer behaviors, but they do not make it easy to see whether full fixture schemas keep model-visible guidance, prune only unreachable definitions, drop unsupported JSON Schema fields, and stay within the Responses API schema budget.

What Changed

  • Added tools/tests/json_schema_policy_fixtures.rs, which converts MCP tool fixtures through mcp_tool_to_responses_api_tool and validates the resulting Responses tool parameters.
  • Added connector-style fixtures for Slack, Google Calendar, Google Drive, Notion, and Microsoft Outlook Email under tools/tests/fixtures/json_schema_policy/.
  • Added fixture assertions for preserved guidance, pruned definitions, expected field drops after JsonSchema conversion, marker count baselines, and dangling local $ref prevention.
  • Added a real oversized golden Notion create_page input schema fixture to exercise the compaction path that strips descriptions, drops root $defs, rewrites local refs, and fits the compacted schema under the budget.

@celia-oai celia-oai changed the title Dev/cc/integration test Add JSON schema policy fixture coverage May 22, 2026
@celia-oai celia-oai changed the title Add JSON schema policy fixture coverage chore: add JSON schema policy fixture coverage May 22, 2026
@celia-oai celia-oai force-pushed the dev/cc/integration-test branch from 7c5fe4c to 4022f47 Compare May 22, 2026 22:00
@celia-oai celia-oai marked this pull request as ready for review May 22, 2026 22:01
@celia-oai
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Keep them coming!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@celia-oai celia-oai requested a review from pakrym-oai May 22, 2026 22:09
@celia-oai celia-oai force-pushed the dev/cc/integration-test branch from 7c7cb16 to 7efc863 Compare May 22, 2026 22:50
@celia-oai celia-oai force-pushed the dev/cc/integration-test branch from 7efc863 to a6813d6 Compare May 22, 2026 23:09
@celia-oai celia-oai merged commit 10ac278 into main May 22, 2026
31 checks passed
@celia-oai celia-oai deleted the dev/cc/integration-test branch May 22, 2026 23:31
@github-actions github-actions Bot locked and limited conversation to collaborators May 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants