[codex] Remove external client session reset plumbing#24157
Merged
Conversation
aibrahim-oai
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The turn loop no longer needs to decide when a
ModelClientSessionshould reset its websocket state after compaction. That reset behavior belongs inside the model client, where the websocket cache and retry state are owned. The repo guidance now calls this out explicitly so future changes let the incremental request logic decide whether the previous request can be reused.What Changed
reset_client_sessionreturn value from pre-sampling and auto-compact helpers incore/src/session/turn.rs.CodexResult<()>so callers only handle success or failure.ModelClientSession::reset_websocket_sessionprivate tocore/src/client.rs, leaving it callable only from model-client internals.AGENTS.mdguidance not to callreset_client_sessionunnecessarily.Validation
just test -p codex-core session::turn