feat(tui): add /app desktop handoff#25638
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 523515fd74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fcoury-oai
force-pushed
the
fcoury/teleport
branch
from
4b26e2d to
6f2b5d5
Compare
fcoury-oai
changed the title
|
@codex review |
etraut-openai
left a comment
etraut-openai
left a comment
There was a problem hiding this comment.
It looks like there are some things unrelated to this PR in this branch, perhaps a bad merge?
Also, there's more complexity here than necessary. I asked codex to apply $simplify-code, and it cut about half the lines out of it (some of them admittedly related to the bad merge).
fcoury-oai
force-pushed
the
fcoury/teleport
branch
from
9faa4dd to
5179725
Compare
|
Rebuilt the branch in 5179725 as one focused commit. I removed the unrelated app-server/state changes, consolidated the Windows and WSL packaged-app launcher, and removed the redundant slash-popup snapshot/tests. The diff is now 6 TUI files with 177 additions, down from 11 files with 336 additions. Validation: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 517972594b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 240dd9c908
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77ee93efba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fcoury-oai
force-pushed
the
fcoury/teleport
branch
3 times, most recently
from
3d564b5 to
8c32df8
Compare
fcoury-oai
changed the title
fcoury-oai
force-pushed
the
fcoury/teleport
branch
from
8c32df8 to
4e2e053
Compare
2 participants
TL;DR
/appopens the current CLI thread in Codex Desktop on macOS and native Windows.Why
TUI users should have a quick handoff into Codex Desktop without having to find or reconstruct the current thread manually. Codex Desktop already supports
codex://threads/<thread-id>deep links, but the TUI needs a Desktop-specific launch path instead of treating the deep link like a normal web URL.This also needs to avoid unsupported environments. In particular, a CLI running inside WSL may use a Linux-side Codex home that the Windows Desktop app cannot see. Sharing the Windows Codex home through
/mnt/calso appears fragile for SQLite-backed local state, so this PR deliberately hides/appon WSL for now rather than offering a command that can launch Desktop but fail to open the session.What Changed
/appto continue the current TUI session in Codex Desktop on macOS and native Windows./apphidden on WSL and ordinary Linux.codex://threads/<thread-id>with native macOSopen.OpenAI.Codexpackaged app through PowerShell withresources/app.asarand the thread deep link, avoiding the MSIX protocol-handler path that can start Electron without its app bundle./appavailable while a task is running./appis invoked before the thread id is available.How to Test
/app./app.Unable to find Electron appdialog./appremains available while the task is running./appbefore the thread id is available and confirm the TUI reports that the session is still starting./appis not offered in the slash-command popup.Manual verification:
just cand/app./appis now intentionally hidden there.Targeted automated verification:
cargo check -p codex-tuijust test -p codex-tui desktop_handoffjust test -p codex-tui app_commandAdditional local notes:
just test -p codex-tuistill fails on two unrelated Guardian tests.just argument-comment-lintis blocked by the existing Bazel/LLVMcompiler-rtempty-glob failure; the touched Rust positional literal callsites were manually inspected.