Skip to content

[codex] Add /usr/bin/bash shell fallback#26538

Merged
pakrym-oai merged 1 commit into
mainfrom
pakrym/full-ci-bash-usr-bin-fallback
Jun 5, 2026
Merged

[codex] Add /usr/bin/bash shell fallback#26538
pakrym-oai merged 1 commit into
mainfrom
pakrym/full-ci-bash-usr-bin-fallback

Conversation

@pakrym-oai

@pakrym-oai pakrym-oai commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Why

Some Linux environments expose bash at /usr/bin/bash instead of /bin/bash. The shell detection fallback list should cover both standard locations once PATH/user-shell probing fails.

Stacked on #26480.

What changed

  • Add /usr/bin/bash to the bash fallback path list in codex-shell-command.
  • Extend shell type detection coverage for /usr/bin/bash.
  • Add AGENTS.md testing guidance to avoid tests for statically defined values and negative tests for removed logic.

Verification

  • just test -p codex-shell-command

Base automatically changed from pakrym/full-ci-environment-shell-info to main June 5, 2026 05:36
@pakrym-oai pakrym-oai force-pushed the pakrym/full-ci-bash-usr-bin-fallback branch from 821ff6c to 85a251b Compare June 5, 2026 05:41
@pakrym-oai pakrym-oai force-pushed the pakrym/full-ci-bash-usr-bin-fallback branch from 85a251b to 6455998 Compare June 5, 2026 05:54
@pakrym-oai pakrym-oai marked this pull request as ready for review June 5, 2026 06:26
@pakrym-oai pakrym-oai merged commit 9ddb1de into main Jun 5, 2026
61 of 78 checks passed
@pakrym-oai pakrym-oai deleted the pakrym/full-ci-bash-usr-bin-fallback branch June 5, 2026 16:38
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants