[codex-rs] Add rust-release action #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oai-ragona
force-pushed
the
codex-rs-release-action
branch
from
662c41e to
a26f1da
Compare
oai-ragona
changed the title
bolinfest
reviewed
Apr 25, 2025
Collaborator
bolinfest
left a comment
bolinfest
left a comment
There was a problem hiding this comment.
Thanks for exploring this! I think my biggest hangup is the version stuff.
We have some GitHub workflows internally where we got fancy with build.rs so we didn't have to make local changes to Cargo.toml to stamp out specific versions if you want a pointer.
wpt-oai
requested changes
Apr 26, 2025
Collaborator
wpt-oai
left a comment
wpt-oai
left a comment
There was a problem hiding this comment.
Nice work hacking this up! Small change req and blocking the merge so I can take a pass later to review our repo / push policies.
wpt-oai
reviewed
Apr 29, 2025
wpt-oai
approved these changes
Apr 29, 2025
Collaborator
wpt-oai
left a comment
wpt-oai
left a comment
There was a problem hiding this comment.
Looking good at this point to me.
bolinfest
approved these changes
Apr 29, 2025
Collaborator
bolinfest
left a comment
bolinfest
left a comment
There was a problem hiding this comment.
Really nice work: ty!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a pass at building artifacts per platform so we can consider different distribution strategies that don't require users to install the full
cargotoolchain.Right now this grabs just the
codex-replandcodex-tuibins for 5 different targets and bundles them into a draft release. I think a clearly marked pre-release set of artifacts will unblock the next step of testing.