From f2d586db9b47bc71ade2cb07fe1c86e076a0b281 Mon Sep 17 00:00:00 2001 From: lionelchg Date: Sun, 16 Nov 2025 17:17:33 -0800 Subject: [PATCH 1/3] Fallback to model_family if no model_reasoning_effort in config Signed-off-by: lionelchg --- codex-rs/common/src/config_summary.rs | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/codex-rs/common/src/config_summary.rs b/codex-rs/common/src/config_summary.rs index dabc606ce1..8fc1bb26f3 100644 --- a/codex-rs/common/src/config_summary.rs +++ b/codex-rs/common/src/config_summary.rs @@ -15,13 +15,12 @@ pub fn create_config_summary_entries(config: &Config) -> Vec<(&'static str, Stri if config.model_provider.wire_api == WireApi::Responses && config.model_family.supports_reasoning_summaries { - entries.push(( - "reasoning effort", - config - .model_reasoning_effort - .map(|effort| effort.to_string()) - .unwrap_or_else(|| "none".to_string()), - )); + let reasoning_effort = config + .model_reasoning_effort + .or(config.model_family.default_reasoning_effort) + .map(|effort| effort.to_string()) + .unwrap_or_else(|| "none".to_string()); + entries.push(("reasoning effort", reasoning_effort)); entries.push(( "reasoning summaries", config.model_reasoning_summary.to_string(), From 137690d36cc9b686aa4c4453fdd29983decd3f73 Mon Sep 17 00:00:00 2001 From: lionelchg Date: Sun, 16 Nov 2025 17:18:28 -0800 Subject: [PATCH 2/3] Add explicitely reasoning medium in gpt-5 and codex defaults Signed-off-by: lionelchg --- codex-rs/core/src/model_family.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/codex-rs/core/src/model_family.rs b/codex-rs/core/src/model_family.rs index b46fae4db7..d7147a04c2 100644 --- a/codex-rs/core/src/model_family.rs +++ b/codex-rs/core/src/model_family.rs @@ -177,6 +177,7 @@ pub fn find_family_for_model(slug: &str) -> Option { base_instructions: GPT_5_CODEX_INSTRUCTIONS.to_string(), apply_patch_tool_type: Some(ApplyPatchToolType::Freeform), support_verbosity: false, + default_reasoning_effort: Some(ReasoningEffort::Medium), ) } else if slug.starts_with("gpt-5.1") { model_family!( @@ -194,6 +195,7 @@ pub fn find_family_for_model(slug: &str) -> Option { supports_reasoning_summaries: true, needs_special_apply_patch_instructions: true, support_verbosity: true, + default_reasoning_effort: Some(ReasoningEffort::Medium), ) } else { None From 5bec3003d80db7f2c85b38c7d590ae231818c247 Mon Sep 17 00:00:00 2001 From: lionelchg Date: Tue, 18 Nov 2025 07:43:35 -0800 Subject: [PATCH 3/3] Revert changing default reasoning for codex and gpt-5 --- codex-rs/core/src/model_family.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/codex-rs/core/src/model_family.rs b/codex-rs/core/src/model_family.rs index 2834b237bd..db37119d1a 100644 --- a/codex-rs/core/src/model_family.rs +++ b/codex-rs/core/src/model_family.rs @@ -179,7 +179,6 @@ pub fn find_family_for_model(slug: &str) -> Option { apply_patch_tool_type: Some(ApplyPatchToolType::Freeform), shell_type: if cfg!(windows) { ConfigShellToolType::ShellCommand } else { ConfigShellToolType::Default }, support_verbosity: false, - default_reasoning_effort: Some(ReasoningEffort::Medium), ) } else if slug.starts_with("gpt-5.1") { model_family!( @@ -197,7 +196,6 @@ pub fn find_family_for_model(slug: &str) -> Option { supports_reasoning_summaries: true, needs_special_apply_patch_instructions: true, support_verbosity: true, - default_reasoning_effort: Some(ReasoningEffort::Medium), ) } else { None