Skip to content

Conversation

@jobchong
Copy link
Contributor

Title: Improve rollout session initialization error messages

Issue: #7283

What: add targeted mapping for rollout/session initialization errors so users get actionable messages when Codex cannot access session files.

Why: session creation previously returned a generic internal error, hiding permissions/FS issues and making support harder.

How:

  • Added rollout::error::map_session_init_error to translate the more common io::Error kinds into user-facing hints (permission, missing dir, file blocking, corruption). Others are passed through directly with CodexErr::Fatal.
  • Reused the mapper in Codex session creation to preserve root causes instead of returning InternalAgentDied.

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jobchong
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 27, 2025
@etraut-openai
Copy link
Collaborator

@codex review

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Collaborator

@etraut-openai etraut-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Overall, this is looking good. I left one suggested change.

@jobchong
Copy link
Contributor Author

I've removed the tests!

@etraut-openai etraut-openai merged commit cbd7d0d into openai:main Nov 27, 2025
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2025
@jobchong jobchong deleted the chore/rollout-error-mapper branch December 2, 2025 04:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants